-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supermaven #10788
Supermaven #10788
Conversation
e81b729
to
4e7dc91
Compare
83e10cc
to
f7a5acb
Compare
f34ccdc
to
2c78ee2
Compare
Co-Authored-By: Kyle <kylek@zed.dev> Co-Authored-By: Nathan <nathan@zed.dev>
Invert the dependency between copilot and editor This should help us merge the `copilot_ui` and `copilot` crates too.
* Improve UI parity on icons with copilot provider * Expose the service tier to `Supermaven` handler Co-authored-by: Max <max@zed.dev>
Co-Authored-By: Max <max@zed.dev>
Co-Authored-By: Max <max@zed.dev>
… working again Co-authored-by: Kyle <kylek@zed.dev>
Next, we'll rename the `copilot_ui` crate to make it provide a status bar menu for both copilot and supermaven Co-authored-by: Kyle <kylek@zed.dev>
Co-authored-by: Kyle <kylek@zed.dev>
Co-authored-by: Kyle <kylek@zed.dev>
Co-Authored-By: Nathan <nathan@zed.dev> Co-Authored-By: Max <max@zed.dev>
Nice! I was able to enable Supermaven with the new |
div().child( | ||
popover_menu("copilot") | ||
.menu(move |cx| { | ||
Some(match status { | ||
Status::Authorized => { | ||
this.update(cx, |this, cx| this.build_copilot_context_menu(cx)) | ||
} | ||
_ => this.update(cx, |this, cx| this.build_copilot_start_menu(cx)), | ||
}) | ||
}) | ||
.anchor(AnchorCorner::BottomRight) | ||
.trigger( | ||
IconButton::new("copilot-icon", icon) | ||
.tooltip(|cx| Tooltip::text("GitHub Copilot", cx)), | ||
), | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this introduced this bug #11537
Fixes prettier entries disappeared after #10788 Release Notes: - N/A
Fixes prettier entries disappeared after zed-industries#10788 Release Notes: - N/A
What's the word on this? I see I can enable it, but sits at "Initializing". |
Adds a supermaven provider for completions. There are various other refactors amidst this branch, primarily to make copilot no longer a dependency of project as well as show LSP Logs for global LSPs like copilot properly.
This feature is not enabled by default. We're going to seek to refine it in the coming weeks.
Release Notes: