Revert "Fix aside affecting parent popover height (#11859)" #11942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3dfa91.
cla-bot
bot
added
the
cla-signed
|
/cherry-pick v0.136.x |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 16, 2024
This reverts commit d3dfa91. This change can cause weird behavior where the completion menu ends up positioned away from the cursor location: <img width="1062" alt="Screenshot 2024-05-16 at 6 43 17 PM" src="https://github.com/zed-industries/zed/assets/1486634/0462a874-4fe3-4ca9-88ce-8d5d0b4009fe"> With the change reverted: <img width="1026" alt="Screenshot 2024-05-16 at 6 43 35 PM" src="https://github.com/zed-industries/zed/assets/1486634/9fc7b9a1-0cfb-4a84-8f6b-b481a785ceca"> Release Notes: - Fixed an issue where the completion menu would sometimes appear detached from the cursor location (preview only).
maxdeviant
added a commit
that referenced
this pull request
May 16, 2024
…ick #11942) (#11944) Cherry-picked Revert "Fix aside affecting parent popover height (#11859)" (#11942) This reverts commit d3dfa91. This change can cause weird behavior where the completion menu ends up positioned away from the cursor location: <img width="1062" alt="Screenshot 2024-05-16 at 6 43 17 PM" src="https://github.com/zed-industries/zed/assets/1486634/0462a874-4fe3-4ca9-88ce-8d5d0b4009fe"> With the change reverted: <img width="1026" alt="Screenshot 2024-05-16 at 6 43 35 PM" src="https://github.com/zed-industries/zed/assets/1486634/9fc7b9a1-0cfb-4a84-8f6b-b481a785ceca"> Release Notes: - Fixed an issue where the completion menu would sometimes appear detached from the cursor location (preview only). Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
osiewicz
pushed a commit
to RemcoSmitsDev/zed
that referenced
this pull request
May 18, 2024
…)" (zed-industries#11942) This reverts commit d3dfa91. This change can cause weird behavior where the completion menu ends up positioned away from the cursor location: <img width="1062" alt="Screenshot 2024-05-16 at 6 43 17 PM" src="https://github.com/zed-industries/zed/assets/1486634/0462a874-4fe3-4ca9-88ce-8d5d0b4009fe"> With the change reverted: <img width="1026" alt="Screenshot 2024-05-16 at 6 43 35 PM" src="https://github.com/zed-industries/zed/assets/1486634/9fc7b9a1-0cfb-4a84-8f6b-b481a785ceca"> Release Notes: - Fixed an issue where the completion menu would sometimes appear detached from the cursor location (preview only).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d3dfa91.
This change can cause weird behavior where the completion menu ends up positioned away from the cursor location:
With the change reverted:
Release Notes: