Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic_text: Handle variation selectors; fix emoji colors #12587

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

apricotbucket28
Copy link
Contributor

@apricotbucket28 apricotbucket28 commented Jun 2, 2024

Basically, we detect if a glyph is a variation selector if its id is 3 (i.e. a whitespace character) and if it comes from an emoji font (since variation selectors are only used for emoji glyphs).

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 2, 2024
@mikayla-maki mikayla-maki merged commit ed86b86 into zed-industries:main Jun 3, 2024
9 checks passed
@mikayla-maki
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when typing b in css file
2 participants