Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlainText language: Default to SoftWrap::EditorWidth #14331

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

notpeter
Copy link
Member

@notpeter notpeter commented Jul 12, 2024

Release Notes:

  • Fixed untitled buffers displaying a soft-wrap wrap-guide at preferred_line_length by default. (#12473).

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 12, 2024
@notpeter notpeter changed the title Plain Text language: default to SoftWrap::EditorWidth "Plain Text" language: default to SoftWrap::EditorWidth Jul 12, 2024
@notpeter notpeter changed the title "Plain Text" language: default to SoftWrap::EditorWidth PlainText language: default to SoftWrap::EditorWidth Jul 12, 2024
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, here's the one.

One concern I have is that whether Zed changes its defaults, this won't be updated — ideally we want to go over every PLAIN_TEXT config usage and ensure a value from the editor settings is taken.

@maxdeviant maxdeviant changed the title PlainText language: default to SoftWrap::EditorWidth PlainText language: Default to SoftWrap::EditorWidth Jul 12, 2024
@notpeter
Copy link
Member Author

One concern I have is that whether Zed changes its defaults, this won't be updated — ideally we want to go over every PLAIN_TEXT config usage and ensure a value from the editor settings is taken.

I noticed this wasn't pulling from the default settings which is why I didn't initially find it. I don't quite understand what you're saying, but would love to pair on it at some point in the future.

@notpeter notpeter merged commit 106e062 into main Jul 12, 2024
12 checks passed
@notpeter notpeter deleted the plain_text_soft_wrap_editorwidth branch July 12, 2024 15:11
SomeoneToIgnore pushed a commit that referenced this pull request Jul 15, 2024
- Remove wrap guide / vertical ruler in untitled buffers
- Fixes #12473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange editor area when showing plain text content
2 participants