Skip to content
This repository has been archived by the owner on Apr 1, 2023. It is now read-only.

Scroll bars white in standalone zed #257

Closed
creationix opened this issue Apr 9, 2014 · 6 comments · Fixed by #438
Closed

Scroll bars white in standalone zed #257

creationix opened this issue Apr 9, 2014 · 6 comments · Fixed by #438

Comments

@creationix
Copy link
Contributor

image

image

@ghost
Copy link

ghost commented Apr 9, 2014

Same on linux
On Apr 9, 2014 10:30 AM, "Tim Caswell" notifications@github.com wrote:

[image: image]https://cloud.githubusercontent.com/assets/89353/2658755/94aa5438-c00c-11e3-9f10-0569d59e27e8.png

[image: image]https://cloud.githubusercontent.com/assets/89353/2658761/a0860bf8-c00c-11e3-8d03-4074fe1a47e5.png


Reply to this email directly or view it on GitHubhttps://github.com//issues/257
.

@ghost
Copy link

ghost commented Apr 10, 2014

I can't seem to reproduce this anymore, so nevermind me, I'm on crack.

@tfwright
Copy link
Contributor

Not seeing this...also on OS X 10.9.2

@allie-wake-up
Copy link
Contributor

I think this happens because of the different mac/win/linux window themes. The mac theme actually uses the default scrollbars intentionally. This produces 2 different results though because of OS X scrollbar settings. In System preferences->general there is a Show scroll bars setting. I think it defaults to being based on mouse or trackpad use. This means if you use a mouse you'll get the white scrollbars and if you use a trackpad you won't.

As for linux, it seems like sometimes on launch the mac theme will briefly load first and the scrollbars will get "stuck".

Also all of these observations are from using the chrome version, but I'm guessing it's the same/similar.

@zefhemel
Copy link
Member

That explains a few things. The question is: can we do anything about it? Can we override these default scrollbars, you seem to suggest we can't?

@allie-wake-up
Copy link
Contributor

We can use custom scrollbars no matter what. Just put all of the ::webkit-scrollbar css on body instead of body.non_mac in editor.css. That should give consistent scrollbars no matter what. I'm not sure if it's possible to use default OS X scrollbars when using a trackpad and custom ones when using a mouse. If we wanted to keep default OS X scrollbars and use custom scrollbars for linux/win I think we could use an ugly hack to force them to change. Something like the following with some timeouts after the mac/non_mac classes on body are changed.

$('.ace_scrollbar').hide();
$('.ace_scrollbar').show();

I think we should just use custom scrollbars no matter what. But I always use a mouse :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants