Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zbctl build does not contain version information #3647

Closed
menski opened this issue Jan 13, 2020 · 0 comments · Fixed by #3648
Closed

zbctl build does not contain version information #3647

menski opened this issue Jan 13, 2020 · 0 comments · Fixed by #3648
Assignees
@menski
Labels
kind/bug Categorizes an issue or PR as a bug scope/clients-go Marks an issue or PR to appear in the Go client section of the changelog

Comments

@menski
Copy link
Contributor

menski commented Jan 13, 2020

Describe the bug

zbctl version shows zbctl development (commit: HEAD) for release build.

To Reproduce

Download zbctl from Zeebe 0.22.0 release and run zbctl version.

Expected behavior

zbctl version should print the version and hash of the released version, i.e. the 0.22.0 release zbctl 0.22.0 (commit: 87e98789).
@menski menski added kind/bug Categorizes an issue or PR as a bug scope/clients-go Marks an issue or PR to appear in the Go client section of the changelog labels Jan 13, 2020
@menski menski self-assigned this Jan 13, 2020
@menski menski mentioned this issue Jan 13, 2020
Merged
3 tasks
ghost pushed a commit that referenced this issue Jan 13, 2020
@menski
Merge #3648
0fc725c 
3648: chore(clients/go): fix set zbctl version and commit during build r=MiguelPires a=menski

## Description

- allow to override the git hash in build script
- add test case to verify version is correctly set

## Related issues

closes #3647 


#

Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
@menski menski mentioned this issue Jan 16, 2020
Merged
ghost pushed a commit that referenced this issue Jan 16, 2020
@menski
Merge #3648
b4d0f9d 
3648: chore(clients/go): fix set zbctl version and commit during build r=MiguelPires a=menski

## Description

- allow to override the git hash in build script
- add test case to verify version is correctly set

## Related issues

closes #3647 


#

Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
ghost pushed a commit that referenced this issue Jan 16, 2020
@menski
Merge #3648
aa96d57 
3648: chore(clients/go): fix set zbctl version and commit during build r=MiguelPires a=menski

## Description

- allow to override the git hash in build script
- add test case to verify version is correctly set

## Related issues

closes #3647 


#

Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
menski added a commit that referenced this issue Jan 16, 2020
@menski
Merge pull request #3684 from zeebe-io/backport/3648
9a86752 
[BACKPORT] chore(clients/go): fix set zbctl version and commit during build

related to #3648 #3647
ghost pushed a commit that referenced this issue Jan 20, 2020
@menski
Merge #3648
beddfb2 
3648: chore(clients/go): fix set zbctl version and commit during build r=MiguelPires a=menski

## Description

- allow to override the git hash in build script
- add test case to verify version is correctly set

## Related issues

closes #3647 


#

Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
@ghost ghost closed this as completed in 85f9f26 Jan 20, 2020
github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
@houssain-barouni
test: fix migration tests (#3647)
0137db6
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@menski menski

Labels
kind/bug Categorizes an issue or PR as a bug scope/clients-go Marks an issue or PR to appear in the Go client section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(clients/go): fix set zbctl version and commit during build camunda/camunda
4 participants
@menski @saig0 @pihme @KerstinHebel