Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add broker steps startup/shutdown metrics #3913

Closed
npepinpe opened this issue Feb 24, 2020 · 2 comments · Fixed by #5535
Closed

Add broker steps startup/shutdown metrics #3913

npepinpe opened this issue Feb 24, 2020 · 2 comments · Fixed by #5535
Labels
good first issue Marks an issue as simple enough for first time contributors kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@npepinpe
Copy link
Member

Is your feature request related to a problem? Please describe.

It would be helpful when deploying changes to know how they impact startup/shutdown (start up in particular is important for quick failover).

Describe the solution you'd like

Add metrics to monitor startup/shutdown time, total and split by steps, so we can see the difference over time.

Describe alternatives you've considered

Checking the logs - works OK-ish, but easy to overlook.
@npepinpe npepinpe added kind/feature Categorizes an issue or PR as a feature, i.e. new behavior good first issue Marks an issue as simple enough for first time contributors labels Feb 24, 2020
@Zelldon Zelldon added scope/broker Marks an issue or PR to appear in the broker section of the changelog Status: Needs Triage and removed Status: Needs Triage labels May 12, 2020
@aivinog1
Copy link
Contributor

@npepinpe Hi, I think I can take this :) If I understand correctly these times (step-by-step: io.zeebe.broker.bootstrap.StartProcess#startStepByStep and io.zeebe.broker.bootstrap.CloseProcess#closingStepByStep) already calculated and just needs to add metrics on these :) I'm thinking that it should be a pie chart with sectors - steps.

@npepinpe
Copy link
Member Author

iirc pie charts in Grafana aren't built-in, so I wouldn't expect most users to have this floating around. I hadn't really thought about it up until now to be honest. We could go with a single gauge metric, with a label for the step itself? As step number can change, maybe we can use the step name as the label value (that's possibly less likely to change).

@aivinog1 aivinog1 mentioned this issue Oct 8, 2020
Merged
8 tasks
ghost pushed a commit that referenced this issue Oct 16, 2020
@aivinog1
Merge #5535
2fd81d4 
5535: chore(broker): Add startup and close processes metrics r=Zelldon a=aivinog1

## Description

Implement metrics to measure the start and close process steps.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #3913 

## Definition of Done

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually
* [ ] The impact of the changes is verified by a benchmark 

Documentation: 
* [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
* [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape)


Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
ghost pushed a commit that referenced this issue Oct 16, 2020
@aivinog1 @Zelldon
Merge #5535 #5574
40263eb 
5535: chore(broker): Add startup and close processes metrics r=Zelldon a=aivinog1

## Description

Implement metrics to measure the start and close process steps.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #3913 

## Definition of Done

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually
* [ ] The impact of the changes is verified by a benchmark 

Documentation: 
* [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
* [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape)


5574: Remove unused atomix configuration options r=Zelldon a=Zelldon

# Description

During cleaning up my last PR I saw that we have a lot of dead code and possibilities of how to configure atomix, which is actually not used.

Removes unused atomix configuration options, like configuration via files etc.



Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
ghost pushed a commit that referenced this issue Oct 16, 2020
@aivinog1
Merge #5535
674fb03 
5535: chore(broker): Add startup and close processes metrics r=Zelldon a=aivinog1

## Description

Implement metrics to measure the start and close process steps.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #3913 

## Definition of Done

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually
* [ ] The impact of the changes is verified by a benchmark 

Documentation: 
* [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
* [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape)


Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
ghost pushed a commit that referenced this issue Oct 16, 2020
@aivinog1
Merge #5535
755bc24 
5535: chore(broker): Add startup and close processes metrics r=Zelldon a=aivinog1

## Description

Implement metrics to measure the start and close process steps.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #3913 

## Definition of Done

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually
* [ ] The impact of the changes is verified by a benchmark 

Documentation: 
* [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
* [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape)


Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
ghost pushed a commit that referenced this issue Oct 19, 2020
@aivinog1
Merge #5535
3eaede8 
5535: chore(broker): Add startup and close processes metrics r=jwulf a=aivinog1

## Description

Implement metrics to measure the start and close process steps.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #3913 

## Definition of Done

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually
* [ ] The impact of the changes is verified by a benchmark 

Documentation: 
* [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
* [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape)


Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
@ghost ghost closed this as completed in f4a4af0 Oct 20, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Marks an issue as simple enough for first time contributors kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(broker): Add startup and close processes metrics aivinog1/zeebe
5 participants
@npepinpe @Zelldon @MiguelPires @KerstinHebel @aivinog1