Remove system partition #4238
Merged
Remove system partition #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthidevaki
approved these changes
Apr 7, 2020
atomix/cluster/src/main/java/io/atomix/primitive/partition/PartitionManagementService.java
Show resolved
Hide resolved
|
I'm not sure whether I can merge this PR the tests arefailing quite often now |
Zelldon
force-pushed
the
zell-remove-system-partition
branch
3 times, most recently
from
16d3c2d
to
5348ca4
Compare
|
Bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
Apr 15, 2020
4238: Remove system partition r=Zelldon a=Zelldon ## Description Removes the system partition from our code base, since it was no longer used. Run a normal benchmark and saw no related issues. I would expect some on start up, if there are any.  I discussed with @deepthidevaki to remove the Bootstrap test, since it is not really deterministic / guaranteed whether the nodes become really leader or not, this means the test was really flaky. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #4166 # Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Build failed |
Remove bootstrap test since the bootstrap and leader distribution is not really determenistic
Zelldon
force-pushed
the
zell-remove-system-partition
branch
from
5348ca4
to
655d167
Compare
|
bors r+ |
Build succeeded |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
….3 (master) (#4238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the system partition from our code base, since it was no longer used.
Run a normal benchmark and saw no related issues. I would expect some on start up, if there are any.
I discussed with @deepthidevaki to remove the Bootstrap test, since it is not really deterministic / guaranteed whether the nodes become really leader or not, this means the test was really flaky.
Related issues
closes #4166
Pull Request Checklist
mvn clean install -DskipTestslocally before committing