Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(benchmarks): add more starters per default #4288

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Apr 9, 2020

Description

To improve our test coverage I added a simple starter and a timer starter. The simple one contains just start event and end event. It is quite interesting to see how the latency behaves on these instances and to just introduce some more load to the broker.
The timer starter contains a workflow with a timer set to PT1S. Per default we will start all of them
to have high load and test that this can be handled by the brokers without any problems.

metrics

Further

I want to add later also workflow with contain message catch events and a pod which just publishes messages.

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry this took so long. One question, the make starter will still start the old single task process?

@Zelldon
Copy link
Member Author

Zelldon commented Apr 16, 2020

Yes correct. Actually here seems a commit missing where I adjusted the makefil. I will add this

To improve our test coverage I added a simple starter and a timer starter. The simple one contains just
start event and end event. It is quite interesting to see how the latency behaves on these instances.
The timer starter contains a workflow with a timer set to PT1S. Per default we will start all of them
to have high load and test that this can be handled by the brokers.
sed -i "s/default/$namespace/g" Makefile
sed -i "s/default/$namespace/g" worker.yaml
sed -i "s/default/$namespace/g" starter.yaml
sed -i "s/default/$namespace/g" Makefile starter.yaml timer.yaml simpleStarter.yaml worker.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know you could do that 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me2 😆 found out accidentally 😄

@Zelldon
Copy link
Member Author

Zelldon commented Apr 22, 2020

bors r+

zeebe-bors bot added a commit that referenced this pull request Apr 22, 2020
4288: chore(benchmarks): add more starters per default r=Zelldon a=Zelldon

## Description

To improve our test coverage I added a simple starter and a timer starter. The simple one contains just start event and end event. It is quite interesting to see how the latency behaves on these instances and to just introduce some more load to the broker.
The timer starter contains a workflow with a timer set to PT1S. Per default we will start all of them
to have high load and test that this can be handled by the brokers without any problems.


![metrics](https://user-images.githubusercontent.com/2758593/78907407-f1d6a500-7a80-11ea-82c7-8a5a5a3a1cab.png)


## Further

I want to add later also workflow with contain message catch events and a pod which just publishes messages.
<!-- Please explain the changes you made here. -->

<!-- Which issues are closed by this PR or are related -->


#

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 22, 2020

Build failed

@Zelldon
Copy link
Member Author

Zelldon commented Apr 23, 2020

bors r+

zeebe-bors bot added a commit that referenced this pull request Apr 23, 2020
4288: chore(benchmarks): add more starters per default r=Zelldon a=Zelldon

## Description

To improve our test coverage I added a simple starter and a timer starter. The simple one contains just start event and end event. It is quite interesting to see how the latency behaves on these instances and to just introduce some more load to the broker.
The timer starter contains a workflow with a timer set to PT1S. Per default we will start all of them
to have high load and test that this can be handled by the brokers without any problems.


![metrics](https://user-images.githubusercontent.com/2758593/78907407-f1d6a500-7a80-11ea-82c7-8a5a5a3a1cab.png)


## Further

I want to add later also workflow with contain message catch events and a pod which just publishes messages.
<!-- Please explain the changes you made here. -->

<!-- Which issues are closed by this PR or are related -->


#

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 23, 2020

Build failed

@Zelldon
Copy link
Member Author

Zelldon commented Apr 23, 2020

bors r+...

@Zelldon Zelldon merged commit 24144cb into develop Apr 23, 2020
@Zelldon Zelldon deleted the zell-testing branch April 23, 2020 16:34
zeebe-bors bot added a commit that referenced this pull request Apr 23, 2020
4288: chore(benchmarks): add more starters per default r=Zelldon a=Zelldon

## Description

To improve our test coverage I added a simple starter and a timer starter. The simple one contains just start event and end event. It is quite interesting to see how the latency behaves on these instances and to just introduce some more load to the broker.
The timer starter contains a workflow with a timer set to PT1S. Per default we will start all of them
to have high load and test that this can be handled by the brokers without any problems.


![metrics](https://user-images.githubusercontent.com/2758593/78907407-f1d6a500-7a80-11ea-82c7-8a5a5a3a1cab.png)


## Further

I want to add later also workflow with contain message catch events and a pod which just publishes messages.
<!-- Please explain the changes you made here. -->

<!-- Which issues are closed by this PR or are related -->


#

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 23, 2020

Build failed

github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2024
…4288)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Houssain Barouni <146710021+houssain-barouni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants