Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT] Do not print confidential information #4729

Merged
merged 3 commits into from
Jun 15, 2020
Merged

[BACKPORT] Do not print confidential information #4729

merged 3 commits into from
Jun 15, 2020

Conversation

npepinpe
Copy link
Member

Description

This PR backports the following PR to 0.23: #4485

Related issues

related to #4482

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@Zelldon @npepinpe
chore(elastic): overwrite toString
715cd4a 
 Add comment that we dont want to print confidential information
@Zelldon @npepinpe
fix(broker): donot print confidential informantion
87a75b9 
 The exporter password and username is replaced with stars to not expose
 them when printing the json on broker bootstrap.
@Zelldon @npepinpe
fix(exporters): don't print confidential information
e6b69e0 
 The authentication is no longer printed on startup
@npepinpe npepinpe requested a review from Zelldon June 15, 2020 12:19
@npepinpe npepinpe self-assigned this Jun 15, 2020
@npepinpe
Copy link
Member Author

bors r+

zeebe-bors bot added a commit that referenced this pull request Jun 15, 2020
@zeebe-bors @Zelldon
Merge #4729
aa59bbd 
4729: [BACKPORT] Do not print confidential information r=npepinpe a=npepinpe

## Description

This PR backports the following PR to 0.23: #4485

## Related issues

related to #4482 

#

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 15, 2020

Build failed

@npepinpe
Copy link
Member Author

bors retry

zeebe-bors bot added a commit that referenced this pull request Jun 15, 2020
@zeebe-bors @Zelldon
Merge #4729
efc9f4a 
4729: [BACKPORT] Do not print confidential information r=npepinpe a=npepinpe

## Description

This PR backports the following PR to 0.23: #4485

## Related issues

related to #4482 

#

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 15, 2020

Build failed

@npepinpe
Copy link
Member Author

bors retry

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 15, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit d2a2628 into stable/0.23 Jun 15, 2020
@zeebe-bors zeebe-bors bot deleted the backports/4482-elastic branch June 15, 2020 14:03
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
@renovate
chore(deps): update alpine docker tag to v3.18.2 (#4729)
73dc272 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees

@npepinpe npepinpe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@npepinpe @Zelldon @csuermann