fix(exporters/elasticsearch-exporter): avoid OOM when retrying #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
approved these changes
Jun 22, 2020
| @@ -118,7 +125,10 @@ public void bulk(final Map<String, Object> command, final Record<?> record) { | |||
| "Failed to serialize bulk request command to JSON", e); | |||
| } | |||
|
|
|||
| bulkRequest.add(serializedCommand + "\n" + record.toJson()); | |||
| final String jsonCommand = serializedCommand + "\n" + record.toJson(); | |||
| if (bulkRequest.isEmpty() || !bulkRequest.get(bulkRequest.size() - 1).equals(jsonCommand)) { | |||
There was a problem hiding this comment.
We could add a comment here why we're filtering it out. I think it is not so obvious.
Comment on lines
156
to
158
| when(recordMock.toJson()).thenReturn("{}"); | ||
| client.index(recordMock); |
There was a problem hiding this comment.
A new-line could improve the reading flow.
Suggested change
| when(recordMock.toJson()).thenReturn("{}"); | |
| client.index(recordMock); | |
| when(recordMock.toJson()).thenReturn("{}"); | |
| client.index(recordMock); |
This was referenced Jun 22, 2020
MiguelPires
force-pushed
the
4668-limit-bulk
branch
from
d04ef34
to
9916533
Compare
|
bors r+ |
Build succeeded |
zeebe-bors bot
added a commit
that referenced
this pull request
Jun 23, 2020
4789: [BACKPORT] fix(exporters/elasticsearch-exporter): avoid OOM exception when retrying r=saig0 a=MiguelPires ## Description Don't append record again when retrying to export, in order to avoid OOM exception. ## Related issues closes #4668 backport of #4787 # Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
zeebe-bors bot
added a commit
that referenced
this pull request
Jun 23, 2020
4790: [BACKPORT] fix(exporters/elasticsearch-exporter): avoid OOM exception when retrying r=saig0 a=MiguelPires ## Description Don't append record again when retrying to export, in order to avoid OOM exception. ## Related issues closes #4668 backport of #4787 # Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vinicius Goulart <vinicius.goulart@camunda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't append record again when retrying to export, in order to avoid OOM exception.
Related issues
closes #4668
Pull Request Checklist
mvn clean install -DskipTestslocally before committing