Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to 0.24] Avoid using default/shared snapshot store factory #5406

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Sep 23, 2020

Description

Backport of fix for #4440

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@GitCop
Copy link

GitCop commented Sep 23, 2020

There were the following issues with your Pull Request

  • Commit: b48d066

  • Commits must be in the following format: %{type}(%{scope}): %{description}

  • Commit: 1a7eafa

  • Commits must be in the following format: %{type}(%{scope}): %{description}

  • Commit: 1aa0bf3

  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/zeebe-io/zeebe/blob/develop/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@pihme pihme changed the base branch from develop to stable/0.24 September 23, 2020 11:20
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@deepthidevaki
Copy link
Contributor

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Sep 24, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit f3772ee into stable/0.24 Sep 24, 2020
@zeebe-bors zeebe-bors bot deleted the 4440-backport-to-0.24 branch September 24, 2020 06:37
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants