Zeek plugin: Respect %port and %mime-type properties in units. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit-side %port and %mime-type may properties may be used instead of specifying them inside the EVT file. Closes #95.
rsmmr
force-pushed
the
topic/robin/gh-95-registering
branch
from
09c8c24
to
0b7cf24
Compare
|
Are port-ranges rare, or is my experience unusual? Both the protocols where I have ever dealt with ports: BACnet and VoIP, use port-ranges rather than single ports. |
I'd say they are rare, yes, but I take your comment as that it would be useful to add support. If you think so, please file a separate feature request ticket. |
bbannier
reviewed
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit-side %port and %mime-type may properties may be used instead of
specifying them inside the EVT file.
Closes #95.