Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdir prefixes not unified in installation #533

Closed
0xxon opened this issue Aug 9, 2019 · 3 comments

Comments

@0xxon
Copy link
Member

commented Aug 9, 2019

On linux, it seems that some library files currently are installed to [prefix]/lib and some library files to [prefix]/lib64

To me more exact, on my installation lib has:

lrwxrwxrwx 1 johanna johanna    9 Aug  9 10:08 broctl -> ./zeekctl
lrwxrwxrwx 1 johanna johanna   14 Aug  9 10:08 libbroker.so -> libbroker.so.2
-rwxr-xr-x 1 johanna johanna  52M Aug  5 15:23 libbroker.so.1.1
lrwxrwxrwx 1 johanna johanna   16 Aug  9 10:08 libbroker.so.2 -> libbroker.so.1.1
-rw-r--r-- 1 johanna johanna 1.4M Jul  1 00:48 libparaglob.a
drwxrwxr-x 3 johanna johanna 4.0K Aug  9 10:08 zeek
drwxrwxr-x 6 johanna johanna 4.0K Aug  9 10:08 zeekctl

And lib64 has:

lrwxrwxrwx 1 johanna johanna   14 Aug  9 10:08 libbinpac.so -> libbinpac.so.0
lrwxrwxrwx 1 johanna johanna   20 Aug  9 10:08 libbinpac.so.0 -> libbinpac.so.0.51-27
-rwxr-xr-x 1 johanna johanna 128K Jul 11 13:36 libbinpac.so.0.51-27

We should probably unify this, so that all libraries are installed into the same directory by default.

@jsiwek jsiwek added this to Unassigned / Todo in Release 3.1.0 via automation Aug 9, 2019

@jsiwek jsiwek added this to the 3.1.0 milestone Aug 9, 2019

@0xxon

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Potentially important note - this happens on Fedora.

@rsmmr rsmmr modified the milestones: 3.1.0, 3.0.0 Aug 9, 2019

@rsmmr rsmmr added this to Unassigned / Todo in Release 3.0.0 via automation Aug 9, 2019

@rsmmr rsmmr removed this from Unassigned / Todo in Release 3.1.0 Aug 9, 2019

@rsmmr

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Changed milestone to 3.0.0, would be nice to fix if it's easy.

@jsiwek

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Sure can look into it, but does impact functionality at all or block a use-case ? Generally wanted to avoid changing things that aren't clearly bugfixes during the RC. The platform-dependent nature of it further degrades my excitement since regressions are more likely to go unnoticed.

@jsiwek jsiwek self-assigned this Aug 12, 2019

@jsiwek jsiwek moved this from Unassigned / Todo to Assigned / In Progress in Release 3.0.0 Aug 12, 2019

jsiwek added a commit that referenced this issue Aug 13, 2019

GH-533: use consistent "lib" install dir
Previously, some sub-projects, like binpac, use GNUInstallDirs.cmake
to choose the default name of the library install directory while
others hard-code "lib" as the default.  The former may pick "lib64"
on some platforms, so for now, when installing such sub-projects as
part of Zeek, it's overridden to consistently be "lib".

@jsiwek jsiwek moved this from Assigned / In Progress to Pending Review / Merge in Release 3.0.0 Aug 13, 2019

rsmmr added a commit that referenced this issue Aug 13, 2019

Merge remote-tracking branch 'origin/topic/jsiwek/gh-533-libdir'
* origin/topic/jsiwek/gh-533-libdir:
  GH-533: use consistent "lib" install dir

rsmmr added a commit that referenced this issue Aug 13, 2019

GH-533: use consistent "lib" install dir
Previously, some sub-projects, like binpac, use GNUInstallDirs.cmake
to choose the default name of the library install directory while
others hard-code "lib" as the default.  The former may pick "lib64"
on some platforms, so for now, when installing such sub-projects as
part of Zeek, it's overridden to consistently be "lib".

@jsiwek jsiwek closed this Aug 14, 2019

Release 3.0.0 automation moved this from Pending Review / Merge to Done Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.