Use object libraries for subdir libs and plugins #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for hunting down the duplicate symbol problem, nice to get this stuff cleaned up a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts 8e7ef00, requires zeek/cmake#12.
After wrestling with duplicate symbol errors (see #643 (comment)), I finally figured out where they came from:
Many subdirectories added the generated
.ccfiles for BIFs via${BIF_OUTPUT_CC}. However, there is no need to compile these files separately. They all end up inzeek/src/Func.cc. Also, some plugins pulled in source files from the parent directory which compiled this file multiple times. All of this works when using static libraries, because the linker drops most symbols when building the finalzeekbinary. With object libraries, we must take care to not build something twice.