Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/doctests.py report errors, but pass #14

Closed
benoitbryon opened this issue Aug 1, 2015 · 0 comments · Fixed by #15
Closed

tests/doctests.py report errors, but pass #14

benoitbryon opened this issue Aug 1, 2015 · 0 comments · Fixed by #15

Comments

@benoitbryon
Copy link
Contributor

Check https://travis-ci.org/zeekay/decorum/jobs/73677996#L154-L193
The build is passing, but it contains some broken doctests.
The build should fail if doctests fail.

I guess that's because doctest.test_file() doesn't raise errors if there are errors.
In https://docs.python.org/3/library/doctest.html#doctest.testfile, I see there is a raise_on_error argument, which default value is False. We may set raise_on_error to True.
benoitbryon added a commit to benoitbryon/decorum that referenced this issue Aug 1, 2015
@benoitbryon
Refs zeekay#14 - Make sure there are doctests in README, and they pass.
d4a247f
@benoitbryon benoitbryon mentioned this issue Aug 1, 2015
Merged
benoitbryon added a commit to benoitbryon/decorum that referenced this issue Aug 1, 2015
@benoitbryon
Refs zeekay#14 - Fixed doctests. Fixed assignation of function name a…
1af9621 
…nd doc. Introduced additional 'updated' option (using functools).
benoitbryon added a commit to benoitbryon/decorum that referenced this issue Aug 1, 2015
@benoitbryon
Refs zeekay#14 - Removed additional 'updated' option: 'assigned' opti…
ddf6f9a 
…on is enough at the moment. Can be restored later as a new feature.
benoitbryon added a commit to benoitbryon/decorum that referenced this issue Aug 1, 2015
@benoitbryon
Refs zeekay#14 - Restored former behaviour of 'assigned' option, but …
e9d3ded 
…keep doctests fixed.
benoitbryon added a commit to benoitbryon/decorum that referenced this issue Aug 1, 2015
@benoitbryon
Refs zeekay#14 - Updated default value of 'assigned' in README.
d3b21c3
benoitbryon added a commit to benoitbryon/decorum that referenced this issue Aug 1, 2015
@benoitbryon
Refs zeekay#14 - Typo in README.
81269b4
benoitbryon added a commit to benoitbryon/decorum that referenced this issue Aug 1, 2015
@benoitbryon
Refs zeekay#14 - Typo in README, again.
ddad2bc
@zeekay zeekay closed this as completed in #15 Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure there are doctests in README benoitbryon/decorum
1 participant
@benoitbryon