-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
score/security: added optional, splitted probes as future replacemnt … #326
Conversation
daa264e
to
5021dea
Compare
@zegl Can you take a look? Some remarks:
|
5021dea
to
10232ea
Compare
…for security context probe Fixes zegl#325
10232ea
to
576930c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! The changes looks good to me, but I'd like it to make the communication about this (future) breakage a bit clearer.
README_SECURITYCONTEXT.md
Outdated
In future releases the `container-security-context` will become *optional* | ||
and replaced by the more detailed checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to commit to the following timeline, and think that it would be a good idea to mention it in this document.
- v1.10: Introduce the three new checks.
- v1.11: Make
container-security-context
optional, and make the three new checks run by default. - v1.12: Remove
container-security-context
.
Since this is going to be a breaking change, I'd like to be as clear as possible with what's going to happen, so that users get a chance to prepare.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks a lot for your contribution.
bors merge
Build succeeded: |
…for security context probe
Fixes #325