Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press and hold keys on OSX causes suggestions popup #1137

Closed
chrisnojima opened this issue Dec 12, 2016 · 9 comments
Closed

Press and hold keys on OSX causes suggestions popup #1137

chrisnojima opened this issue Dec 12, 2016 · 9 comments

Comments

@chrisnojima
Copy link

  • OS version and name: OSX 10.12.1
  • Hyper.app version: 1.0.0.1303
  • Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere): NA
  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

Just updated to 1.0.0, now when I'm in neovim if i press and hold down the 'L' key instead of repeating the movements, it also flickers the popup to enter 'ł'. It also seems to affect all keys as pressing and holding jkli keys seems sluggish. Was fine before this and is still fine in iterm. See attached gif which captures a subset of the popups flashing

press hold neovim

@jessemillar
Copy link

jessemillar commented Dec 12, 2016

Same issue here. Experienced on the same OS inside normal vim.

For now, you can disable this feature system-wide with the following command:

defaults write -g ApplePressAndHoldEnabled -bool false

@xvalentino
Copy link

Noticed this too. Anyone have any ideas as to why this would happen here and not in iTerm? You can also disable this on a per app basis. https://gist.github.com/rastasheep/bfc8266eeb58b899054c

@xvalentino
Copy link

We could probably use this. Maybe in a plugin? electron/electron#8084

@detj
Copy link

detj commented Jan 21, 2017

Yeah, this is pretty annoying. Solved it by running

defaults write co.zeit.hyper ApplePressAndHoldEnabled -bool false

This should be made in to a plugin.

@roolebo
Copy link

roolebo commented Mar 11, 2017

systemPreferences.setUserDefault from electron can be used to disable ApplePressAndHoldEnabled as @xvalentino pointed out.

However I think it should be part of core rather than a plugin. Accent pop-up is designed for input fields where caret doesn't move when user holds a key. Hyper caret behaviour is different, it always moves, so there's no point to have the pop-up window as it appears and disappears without letting user to select an accent.

@sukima
Copy link

sukima commented Dec 1, 2018

This is still happening with Hyper 2.0 on Mojave. Is there a reason this was closed and abandoned?

@cwervo
Copy link

cwervo commented Dec 20, 2018

@sukima This was fixed in 2017 but broke again recently. Looks like @chabou fixed it a few days ago, see #3317 This fix should be live whenever v2.1.1 comes out.

@jflatow
Copy link

jflatow commented May 9, 2019

This still seems to be a real issue in Hyper 3.x.x

@jasongaare
Copy link

Also seeing this in Hyper 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants