Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keymap to open hamburger menu without using the mouse #3443

Closed
2 tasks done
gwojan opened this issue Jan 25, 2019 · 15 comments · Fixed by #4685
Closed
2 tasks done

Add keymap to open hamburger menu without using the mouse #3443

gwojan opened this issue Jan 25, 2019 · 15 comments · Fixed by #4685
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper

Comments

@gwojan
Copy link

gwojan commented Jan 25, 2019

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10, 1803
  • Hyper.app version: hyper 3.0.0-canary.6 (canary)

Issue

I would really like to be able to open the hamburger menu from the keyboard. I have checked the default mappings for hyper and don't see anything related to the hamburger menu.

@chabou chabou added 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper help wanted Contributions wanted towards the issue good first issue Issue is good for Hyper newcomers labels Jan 25, 2019
@Stanzilla
Copy link
Collaborator

Should be the ALT key on Windows if it gets added

@doniyor2109
Copy link
Contributor

Hi. Can I work on this issue?

@Stanzilla
Copy link
Collaborator

Sure, go ahead :)

@doniyor2109
Copy link
Contributor

@Stanzilla Should we add hotkey for linux?

@Stanzilla
Copy link
Collaborator

I'm not familiar with the conventions on Linux so probably not the best person to ask :(

@chabou
Copy link
Collaborator

chabou commented Jan 26, 2019

@juancampa any thought?

@doniyor2109
Copy link
Contributor

@chabou How about ctrl+` ?

@juancampa
Copy link
Contributor

juancampa commented Feb 22, 2019

I think it's fine to have the same hotkey on Linux, as long as it's customizable. I personally use i3wm withhout any decorations so I normally don't see/use menus. And I have removed it from Hyper as well with custom css in my ~/hyper.js

@jsrj
Copy link

jsrj commented May 14, 2019

If it hasn't already been done, mind if I add the same functionality for Mac?

@JoffreyGe
Copy link

@jsrj just a question, why do you want to add a shortcut on something ignored on Mac?
// default: true on Linux, true on Windows, ignored on macOS
If the burgerMenu can be displayed on macOS could you show me?

@AkashDhiman
Copy link

Is the issue still active? Can I work on it?

@Stanzilla
Copy link
Collaborator

Sure, go ahead :)

@Amagon96
Copy link

I didn't see a merge requesto for this issue, is still opened? 😮

@Lunchb0ne
Copy link

Maybe add support for remapping it?

@LabhanshAgrawal
Copy link
Collaborator

Maybe add support for remapping it?

You can just map the shortcut for window:hamburgerMenu in your config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

Successfully merging a pull request may close this issue.