Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update notification link #2637

Merged
merged 2 commits into from Jan 24, 2018
Merged

Fix update notification link #2637

merged 2 commits into from Jan 24, 2018

Conversation

ppot
Copy link
Contributor

@ppot ppot commented Jan 23, 2018 •
edited

Update releaseUrl in a way that updateUrl don't override the tag url

close #2636

@Stanzilla
Copy link
Collaborator

@ppot nice! build failed because of a linting error btw:

C:\projects\hyper\lib\components\notifications.js
  83:13  error  Delete `··⏎············`  prettier/prettier

@ppot
Copy link
Contributor Author

ppot commented Jan 24, 2018

@Stanzilla Ya don't know how prettier work 😂

@Stanzilla
Copy link
Collaborator

@ppot yarn run lint --fix :D

@ppot
Copy link
Contributor Author

ppot commented Jan 24, 2018

Fixed

@ppot ppot merged commit dc3155f into canary Jan 24, 2018
@ppot ppot deleted the fix/releases_notes branch January 24, 2018 18:23
@albinekb
Copy link
Contributor

👍

@parktheredcar parktheredcar mentioned this pull request Dec 7, 2018
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update notification "Notes" link is probably wrong
3 participants
@ppot @Stanzilla @albinekb