Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

Upgrade @babel/preset-typescript to 7.0.0-rc.1 #242

Merged
merged 1 commit into from Aug 13, 2018
Merged

Upgrade @babel/preset-typescript to 7.0.0-rc.1 #242

merged 1 commit into from Aug 13, 2018

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Aug 9, 2018

This is a follow-up to #236, which should close #227.

Context: #236 (comment)

@@ -5,7 +5,7 @@
"license": "MIT",
"repository": "zeit/next-plugins",
"dependencies": {
"@babel/preset-typescript": "7.0.0-beta.42"
"@babel/preset-typescript": "7.0.0-rc.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is an RC, can the dependency be declared as "^7.0.0-rc.1" (with ^)?

@timneutkens
Copy link
Member

Next.js has to be upgraded first

@kachkaev
Copy link
Contributor Author

kachkaev commented Aug 9, 2018

Will it be necessary to change anything there or will it be a simple version bump? Also curious what you think about adding ^ (see comment above).

@kachkaev
Copy link
Contributor Author

Here's a simple PR to next.js that bumps babel version: vercel/next.js#4937

timneutkens pushed a commit to vercel/next.js that referenced this pull request Aug 13, 2018
Fixes #4691
Fixes #4614

This PR gives path to vercel/next-plugins#242

I did not add or remove `^` near dependency versions in package.json files. However, I don't exclude that some changes can be made given that rc is more stable than beta.
@timneutkens timneutkens merged commit 9f32bcd into vercel:canary Aug 13, 2018
@kachkaev
Copy link
Contributor Author

Glad to see next@7.0.0-canary.0 released recently! I'll be happy to test it with a few plugins once their versions are bumped and so @babel/* is 7.0.0-rc.1 everywhere! 🙂

@kachkaev
Copy link
Contributor Author

@timneutkens WDYT of bumping plugin versions?

@timneutkens
Copy link
Member

I released as @canary this weekend

@timneutkens
Copy link
Member

But if there's any left please upgrade them 👌

@kachkaev
Copy link
Contributor Author

Oh, I totally missed the new tags in the repo – that was dull 😅 Turns out that I was confused by npm-check-updates, which did not list up the updates in plugins for some reason this morning. Sorry for this unnecessary spam!

@timneutkens
Copy link
Member

No worries at all 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants