Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Babel to 7.0.0-rc.1 (major) #4937

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Upgrade Babel to 7.0.0-rc.1 (major) #4937

merged 2 commits into from
Aug 13, 2018

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Aug 10, 2018

Fixes #4691
Fixes #4614

This PR gives path to vercel/next-plugins#242

I did not add or remove ^ near dependency versions in package.json files. However, I don't exclude that some changes can be made given that rc is more stable than beta.

@bensalilijames
Copy link
Contributor

This should fix #4614 too! 🙌

@timneutkens timneutkens changed the title Upgrade babel dependencies to 7.0.0-rc.1 Upgrade Babel to 7.0.0-rc.1 (major) Aug 13, 2018
@timneutkens timneutkens merged commit 9319c15 into vercel:canary Aug 13, 2018
@kachkaev
Copy link
Contributor Author

kachkaev commented Aug 21, 2018

@timneutkens 7.0.0-rc.2 is out and I will be happy to submit a new PR to this repo and to next-plugins. Do you pre-approve? I'm also wondering if we can simply specify ^7.0.0-rc.2 for all babel stuff given that RCs are usually more stable than beta. This will remove a need to bump next canary every time a new RC is out. WDYT?

If anything really bad happens in any of the RCs, canary testers will be able to manually freeze package versions in their package.json

@brainkim
Copy link
Contributor

You can do “^7.0.0-r” if you want install the higest release candidate version

@timneutkens
Copy link
Member

From earlier tweets babel 7 will be out this week

@kachkaev
Copy link
Contributor Author

👍 great, let's wait!

@schoenwaldnils
Copy link
Contributor

Babel 7.0.0 is out 🎉

@kachkaev
Copy link
Contributor Author

@timneutkens will you be happy to accept a simple PR? Does anything need changing apart from the version bump?

@kachkaev
Copy link
Contributor Author

kachkaev commented Aug 28, 2018

Ah, it's already done! #5042 😅 👍

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next 6 with Babel 7 beta Flow Type Error with Next.js 6
5 participants