Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-sentry sample doesn't log to sentry for componentDidUpdate and render #11311

Closed
jojonarte opened this issue Mar 24, 2020 · 2 comments
Closed
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@jojonarte
Copy link

Bug report

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. git clone git@github.com:zeit/next.js.git
  2. cd next.js/examples/with-sentry
  3. Change with own sentry dsn
  4. npm install
  5. npm build; npm start
  6. Click Raise the error in render then click report
  7. Click Raise the error in componentDidUpdate then click report

Expected behavior

I expect the error to be raised in sentry. I can only seem to get error for the getInitialProps but not for the render and componentDidUpdate

Screenshots

Screen Shot 2020-03-24 at 10 46 47 AM

System information

  • OS: macOS
  • chrome
  • "next": "latest"
@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers help wanted labels Mar 24, 2020
@nicobarray
Copy link

Hi guys 👋

Just cloned a fresh repo, built and ran it with npm & yarn and everything seem fine to me:

  • Raise error in render: the sentry is sent and the manual error report too.
  • Raise error in componentDidUpdate: the sentry is sent and the manual error report too.
  • Raise error in getInitialProps of client-loaded page: the sentry is sent and the manual error report too.
  • Raise error in getInitialProps of server-loaded page: the sentry is sent and the manual error report too.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants