-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate replacing lib/EventEmitter.js with mitt #4908
Comments
@DullReferenceException could you check this out maybe? |
Mitt is awesome but in my opinion "not very node like".
|
@HaNdTriX it doesn't really matter when all we do is provide the |
No not at all. I am actually fine with using mitt. I just wanted to point out the differences. The issue that was fixed by @DullReferenceException here b492e67 will be reintroduced though. (chaining & emit returns boolean) |
Probably an ok compromise. If the |
With the current version, |
@lucleray yes it would still be worth replacing it imo. |
This PR aims at replacing next-server/lib/event-emitter.js by mitt. Fix #4908 event-emitter.js is ~400 bytes gzipped vs mitt is 200 bytes
https://github.com/developit/mitt
Mitt is 277 Bytes
EventEmitter.js is around 1.07KB
They have the same functionality from what I've seen.
The text was updated successfully, but these errors were encountered: