Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lint-staged #12225

Merged
merged 10 commits into from
May 2, 2020
Merged

Update lint-staged #12225

merged 10 commits into from
May 2, 2020

Conversation

matamatanot
Copy link
Contributor

https://github.com/okonet/lint-staged#migration

From v10.0.0 onwards any new modifications to originally staged files will be automatically added to the commit. If your task previously contained a git add step, please remove this. The automatic behaviour ensures there are less race-conditions, since trying to run multiple git operations at the same time usually results in an error.

From v10.0.0 onwards lint-staged requires Node.js version 10.13.0 or later.

@matamatanot matamatanot requested a review from Timer as a code owner April 27, 2020 03:25
@ijjk
Copy link
Member

ijjk commented Apr 27, 2020

Failing test suites

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 1024
Received:    1076

  82 |     // These numbers are without gzip compression!
  83 |     const delta = responseSizesBytes - 257 * 1024
> 84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
     |                   ^
  85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
  86 |   })
  87 | 

  at Object.<anonymous> (integration/size-limit/test/index.test.js:84:19)

@ijjk
Copy link
Member

ijjk commented Apr 27, 2020

Failing test suites

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 1024
Received:    1076

  82 |     // These numbers are without gzip compression!
  83 |     const delta = responseSizesBytes - 257 * 1024
> 84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
     |                   ^
  85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
  86 |   })
  87 | 

  at Object.<anonymous> (integration/size-limit/test/index.test.js:84:19)

@ijjk
Copy link
Member

ijjk commented Apr 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary matamatanot/next.js update-lint-staged Change
buildDuration 12s 11.8s -240ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary matamatanot/next.js update-lint-staged Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.037 1.992 -0.04
/ avg req/sec 1227.17 1255.08 ⚠️ +27.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.02 1.03 ⚠️ +0.01
/error-in-render avg req/sec 2449.81 2428.13 -21.68
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.js gzip 6.27 kB 6.27 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ac5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary matamatanot/next.js update-lint-staged Change
index.html gzip 927 B 927 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary matamatanot/next.js update-lint-staged Change
buildDuration 12.4s 12.7s ⚠️ +236ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.js gzip 6.27 kB 6.27 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..ac5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_error.js 558 kB 558 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 558 kB 558 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 587 kB 587 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member

ijjk commented May 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary matamatanot/next.js update-lint-staged Change
buildDuration 12.2s 12.3s ⚠️ +87ms
nodeModulesSize 56.4 MB 56.4 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary matamatanot/next.js update-lint-staged Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.095 2.102 ⚠️ +0.01
/ avg req/sec 1193.58 1189.39 -4.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.349 1.413 ⚠️ +0.06
/error-in-render avg req/sec 1853.26 1769.58 -83.68
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary matamatanot/next.js update-lint-staged Change
index.html gzip 927 B 927 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary matamatanot/next.js update-lint-staged Change
buildDuration 13s 13.1s ⚠️ +12ms
nodeModulesSize 56.4 MB 56.4 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary matamatanot/next.js update-lint-staged Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary matamatanot/next.js update-lint-staged Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓

Timer
Timer reviewed May 2, 2020
View reviewed changes
lint-staged.config.js Outdated Show resolved Hide resolved
@Timer Timer added this to the 9.3.7 milestone May 2, 2020
@Timer
Copy link
Member

Timer commented May 2, 2020

Thanks!

@Timer Timer merged commit 5787cbd into vercel:canary May 2, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@matamatanot @rokinsky
Update lint-staged (vercel#12225)
6043f22
@matamatanot matamatanot deleted the update-lint-staged branch October 30, 2021 09:54
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matamatanot @ijjk @Timer