Specify a different build directory for #1513 #1599
Conversation
There was a problem hiding this comment.
This looks pretty great for me. I need to see following changes:
- Use
distDirin the config instead ofoptions.dist - Create a integration test where we use a different build dir. Use a project like this.
Here we need to see whether the app is working properly and check whether the distDir exist.
server/config.js
Outdated
| @@ -5,7 +5,10 @@ const cache = new Map() | |||
|
|
|||
| const defaultConfig = { | |||
| webpack: null, | |||
| poweredByHeader: true | |||
| poweredByHeader: true, | |||
| options: { | |||
There was a problem hiding this comment.
No need options object.
Shall we use distDir instead.
|
@arunoda Wondering if it's worth adding something for this to the examples folder? |
|
@alexnewmannn may be as a different PR. |
|
@arunoda Hey, I've addressed your comments, added the integration test (hopefully that's what you were after...) and also added |
| @@ -0,0 +1,7 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Change the dir name of this integration test from distDir to dist-dir.
|
@alexnewmannn this is pretty cool. We can take this. |
|
@arunoda Updated, any other changes needed? Happy to update if so, wasn't sure if that was the best way to approach the tests. |
| @@ -11,3 +11,5 @@ npm-debug.log | |||
| # coverage | |||
| .nyc_output | |||
| coverage | |||
|
|
|||
| .DS_Store | |||
There was a problem hiding this comment.
I believe we removed the .DS_Store a million times in PRs 馃槄
There was a problem hiding this comment.
There was a problem hiding this comment.
Maybe we should just add .DS_Store like it's done in this PR 馃槃
There was a problem hiding this comment.
Haha, yeh I have one setup just not on my personal laptop (don't use it much 馃憖 ) just thought it might be useful as I'm probably not the only one. Can remove if you want?
|
This is awesome. Thanks. |
Fixes #1513
This allows the user to setup a custom dist folder, instructions on how to do it is added in the README.md (not sure i've used the best wording, so open to that)
Let me know if I've missed anything but it seems to work with all the commands, runs fine and has a default config.
Let me know! 馃憤