Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example for usage with rematch #4095

Merged
merged 3 commits into from Apr 3, 2018
Merged

Added example for usage with rematch #4095

merged 3 commits into from Apr 3, 2018

Conversation

imbhargav5
Copy link
Contributor

@imbhargav5 imbhargav5 commented Apr 2, 2018 •
edited by timneutkens

Fixes #4076

This example helps setting up the following with rematch.

  • A standard counter example which has both sync and asynchronous actions
  • A github user page which is predominantly asynchronous and shows a good example for fetching data from the server
  • Server side rendered initial state
  • Specifying initialState for a particular model in createStore.

@timneutkens
Copy link
Member

timneutkens commented Apr 2, 2018 •
edited

Please run yarn lint --fix locally. PR looks great 👍

@timneutkens
Copy link
Member

Very nice!

@timneutkens timneutkens merged commit 3556a3a into vercel:master Apr 3, 2018
lependu pushed a commit to lependu/next.js that referenced this pull request Apr 17, 2018
@imbhargav5 @lependu
Added example for usage with rematch (vercel#4095)
1545a52 
* Usage with rematch

* Run lint fix

* Add counter-display example and readme
timneutkens pushed a commit that referenced this pull request Apr 18, 2018
@imbhargav5 @timneutkens
Added example for usage with rematch (#4095)
5187d14 
* Usage with rematch

* Run lint fix

* Add counter-display example and readme
@lock lock bot locked as resolved and limited conversation to collaborators Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imbhargav5 @timneutkens