Make sure props.url is immutable #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyis
approved these changes
May 12, 2018
leo
approved these changes
May 12, 2018
|
@timneutkens Should we make the router values immutable too? |
lependu
pushed a commit
to lependu/next.js
that referenced
this pull request
Jun 19, 2018
* Make sure props.url is immutable * Add test for immutable url * Match object instead of string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation of the automatic
urlinjection introduced this, basicallyrouteris mutable, and getting the value at call time will break when someone checks it incomponentWillUpdateor similar.