Update with-electron example #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
force-pushed
the
electron-2
branch
3 times, most recently
from
7501af4
to
3efa282
Compare
Electron recommends to disable nodeIntegration in BrowserViews. This PR follows this recommendation and updates the example accordingly. Changes: - disable nodeIntegration - update dependencies
timneutkens
approved these changes
May 16, 2018
lependu
pushed a commit
to lependu/next.js
that referenced
this pull request
Jun 19, 2018
Electron recommends to disable nodeIntegration in BrowserViews. This PR follows this recommendation and updates the example accordingly. Changes: - disable nodeIntegration - update dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron recommends to disable
nodeIntegrationinBrowserViews.This PR follows this recommendation and updates the example accordingly.
Changes
nodeIntegrationRelated Issues: