Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support flex: 1 and and tag support Dimensions #4460

Merged
merged 2 commits into from
May 23, 2018
Merged

added support flex: 1 and and tag support Dimensions #4460

merged 2 commits into from
May 23, 2018

Conversation

gHashTag
Copy link
Contributor

Users react-native love flex: 1 and added support for the tag Dimensions

@gHashTag
Copy link
Contributor Author

@dcalhoun I think this addition is necessary for your example.

timneutkens
timneutkens approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@timneutkens timneutkens merged commit 763ddc0 into vercel:canary May 23, 2018
lependu pushed a commit to lependu/next.js that referenced this pull request Jun 19, 2018
@gHashTag @lependu
added support flex: 1 and and tag support Dimensions (vercel#4460)
9776744
@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gHashTag @dcalhoun @timneutkens