Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make next/link async safe #4911

Merged
merged 4 commits into from
Aug 7, 2018
Merged

Make next/link async safe #4911

merged 4 commits into from
Aug 7, 2018

Conversation

timneutkens
Copy link
Member

Removes componentWillMount and uses memoize instead as recommended here: https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html

@timneutkens timneutkens merged commit a528565 into vercel:canary Aug 7, 2018
@timneutkens timneutkens deleted the fix/async-safe-next-link branch August 7, 2018 05:44
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rauchg rauchg rauchg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @rauchg