-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crossOrigin via props to _document Head and NextScript #5646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great! The only thing missing is a test for this new behavior.
You can add this test to |
Ah yes, good idea. Thanks for telling me which one, that was very helpful. Tests do not seem to work on windows for me but I was able to WSL them following this: https://github.com/zeit/next.js/blob/canary/contributing.md Unfortunately the tests seem to fail on CircleCI but pass fine on my local machine: |
Thanks for your help. I will spend some time figuring out how to get my tests working right. |
Great PR @Enalmada! |
Thank you @timneutkens and @Enalmada! Can't wait to see this in a release 🎉 |
@jclem didn't know you were running into this at GitHub 😄 Feel free to DM me on spectrum/twitter if you run into specific issues. |
This alternative implementation of #5150 follows @timneutkens suggestion of using props.
Fixes #5150
Fixes #3630