Generate correct 404 on export #6274
Conversation
| @@ -28,7 +28,8 @@ process.on( | |||
| await sema.acquire() | |||
| const { page, query = {} } = exportPathMap[path] | |||
| const req = { url: path } | |||
| const res = {} | |||
| const res = path === '/404.html' ? { statusCode: 404 } : {} | |||
There was a problem hiding this comment.
The proposed solution in #6243 didn't work since err wasn't actually null when exporting. I was a bit worried defaulting to 404 for any scenario directly in _error.js would have the potential to bite us further down the line, so maybe this might work as an alternative?
| expect(html).toMatch(/404/) | ||
| }) | ||
|
|
||
| it('should export 404.html instead of 404/index.html', async () => { |
There was a problem hiding this comment.
I wasn't sure if creating a new test-suite for this test alone would be worth it considering the added time for CI etc. I think a export-default suite with more tests than this one would make sense though.
|
I don't think this PR makes sense now that #6276 closed the issue. We should still add |
|
Hey @Ephem sorry about the double work! We'd love to get those tests fixed and look forward to your PR! |
|
No worries, we approached this mainly from two different issues, it happens. :) I've learned a lot of valuable things and found some other stuff to improve working on this so time wasn't wasted at all! :) |
|
Superseded by #6912 |
This PR fixes a couple of issues around 404-pages when exporting:
404.htmlwhen exporting is now a correct 404-page (Fixes Error page displays invalid information #6243)/404.htmlis not provided inexportPathMap, add the default one/test/integration/export/test/integration/exportThe tests matched for
/404/in the html, but the default error page from the static Express server used in the tests includes this, causing false positives.The test that was removed was
should export 404.html instead of 404/index.html. Because this logic only applies todefaultPathMapand this test-suite defines a custom configuration, there is to my knowledge currently no way to test this without adding a new test-suite.The options as I see it:
export-default(Scope-creep for this PR? Won't have time to do it next few days)exportPathMapas well