Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert weird firefox workaround #6896

Merged
merged 3 commits into from Apr 4, 2019
Merged

Revert weird firefox workaround #6896

merged 3 commits into from Apr 4, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 4, 2019 •
edited

This workaround originally addressed #3817 which is an edge case but introduced #6882 which is much worse so this reverts it.

Closes: #3817

Timer
Timer approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js revert/firefox-workaround Change
Build Duration 13s 12.2s -752ms
node_modules Size 43.9 MB 43.9 MB -1.24 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.1 kB -65 B
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB -197 B
Client commons gzip Size 59.5 kB 59.5 kB -65 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Build Dir Size 345 kB 345 kB -197 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js revert/firefox-workaround Change
Build Duration 16s 16.3s ⚠️ +292ms
node_modules Size 43.9 MB 43.9 MB -1.24 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.1 kB -65 B
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB -197 B
Client commons gzip Size 59.5 kB 59.5 kB -65 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 226 kB 225 kB -203 B
Serverless pages/link gzip Size 59.2 kB 59 kB -189 B
Serverless pages/index Size 221 kB 220 kB -203 B
Serverless pages/index gzip Size 58 kB 57.8 kB -190 B
Serverless pages/_error Size 222 kB 222 kB -203 B
Serverless pages/_error gzip Size 58 kB 57.8 kB -190 B
Serverless pages/routerDirect Size 221 kB 221 kB -203 B
Serverless pages/routerDirect gzip Size 58 kB 57.8 kB -191 B
Serverless pages/withRouter Size 221 kB 221 kB -203 B
Serverless pages/withRouter gzip Size 58 kB 57.9 kB -190 B
Build Dir Size 1.33 MB 1.33 MB -1.21 kB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js revert/firefox-workaround Change
Build Duration 13.6s 14.3s ⚠️ +704ms
node_modules Size 43.9 MB 43.9 MB -1.24 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.1 kB -65 B
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB -197 B
Client commons gzip Size 59.5 kB 59.5 kB -65 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Build Dir Size 345 kB 345 kB -197 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js revert/firefox-workaround Change
Build Duration 17.6s 17.9s ⚠️ +230ms
node_modules Size 43.9 MB 43.9 MB -1.24 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.1 kB -65 B
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB -197 B
Client commons gzip Size 59.5 kB 59.5 kB -65 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 226 kB 225 kB -203 B
Serverless pages/link gzip Size 59.2 kB 59 kB -192 B
Serverless pages/index Size 221 kB 220 kB -203 B
Serverless pages/index gzip Size 58 kB 57.8 kB -192 B
Serverless pages/_error Size 222 kB 222 kB -203 B
Serverless pages/_error gzip Size 58 kB 57.8 kB -192 B
Serverless pages/routerDirect Size 221 kB 221 kB -203 B
Serverless pages/routerDirect gzip Size 58 kB 57.8 kB -193 B
Serverless pages/withRouter Size 221 kB 221 kB -203 B
Serverless pages/withRouter gzip Size 58 kB 57.9 kB -194 B
Build Dir Size 1.33 MB 1.33 MB -1.21 kB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js revert/firefox-workaround Change
Build Duration 14.4s 12.6s -1.8s
node_modules Size 43.9 MB 43.9 MB -1.24 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.1 kB -65 B
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB -197 B
Client commons gzip Size 59.5 kB 59.5 kB -65 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Build Dir Size 345 kB 345 kB -197 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js revert/firefox-workaround Change
Build Duration 18s 17.3s -662ms
node_modules Size 43.9 MB 43.9 MB -1.24 kB
Total Bundle (main, webpack, commons) Size 208 kB 208 kB -197 B
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.1 kB -65 B
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.8 kB 22.8 kB ✓
Client main gzip Size 7.37 kB 7.37 kB ✓
Client commons Size 183 kB 183 kB -197 B
Client commons gzip Size 59.5 kB 59.5 kB -65 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 226 kB 225 kB -203 B
Serverless pages/link gzip Size 59.2 kB 59 kB -192 B
Serverless pages/index Size 221 kB 220 kB -203 B
Serverless pages/index gzip Size 58 kB 57.8 kB -192 B
Serverless pages/_error Size 222 kB 222 kB -203 B
Serverless pages/_error gzip Size 58 kB 57.8 kB -191 B
Serverless pages/routerDirect Size 221 kB 221 kB -203 B
Serverless pages/routerDirect gzip Size 58 kB 57.8 kB -193 B
Serverless pages/withRouter Size 221 kB 221 kB -203 B
Serverless pages/withRouter gzip Size 58 kB 57.9 kB -195 B
Build Dir Size 1.33 MB 1.33 MB -1.21 kB

@ijjk ijjk merged commit 682b3ed into vercel:canary Apr 4, 2019
@ijjk ijjk deleted the revert/firefox-workaround branch April 4, 2019 20:35
@jaycenhorton jaycenhorton mentioned this pull request Apr 27, 2019
Closed
2 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox loses query string after a Router.replace shallow
2 participants
@ijjk @Timer