Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0.4 weird issue with firefox & query parameters in the url #6882

Closed
quantizor opened this issue Apr 3, 2019 · 7 comments
Closed

8.0.4 weird issue with firefox & query parameters in the url #6882

quantizor opened this issue Apr 3, 2019 · 7 comments
Assignees

Comments

@quantizor
Copy link
Contributor

quantizor commented Apr 3, 2019

Bug report

there seems to be a regression in 8.0.4 specifically for newer versions of Firefox relating to next/router code

Describe the bug

when landing on a page that contains query parameters, the browser becomes "locked" to that page and programmatically or manually navigating to a different same-domain page insta-redirects back to the original. note that this does not start happening until a query parameter is involved in the url, totally bizarre

System information

  • OS: macOS
  • Browser (if applies) firefox 66
  • Version of Next.js: 8.0.4

Additional context

Downgrading to 8.0.3 fixes this issue, so it's definitely something in nextjs. The two ways my (private) project moves between pages is typical anchor links and using window.location.assign.

@quantizor quantizor changed the title 8.0.4 weird issue with firefox & usage of window.location.assign 8.0.4 weird issue with firefox & query parameters in the url Apr 3, 2019
@ijjk
Copy link
Member

ijjk commented Apr 3, 2019

Probably related to #3817 and #6630

@quantizor
Copy link
Contributor Author

Yeah #6630 looks to probably be it. Can we revert?

@ijjk
Copy link
Member

ijjk commented Apr 4, 2019

It has been reverted, thanks for the info 👍

@ijjk ijjk closed this as completed Apr 4, 2019
@kachkaev
Copy link
Contributor

@Timer @ijjk @timneutkens folks, when about are you planning to release the next stable version? If it's still at least a few days away, WDYT of marking next 8.0.3 on npm as latest instead of 8.0.4? Otherwise, lot of folks are downloading a version that has a pretty serios issue on FF, one of the most popular browsers 😬

@helsner
Copy link

helsner commented Apr 16, 2019

@kachkaev we're using 8.0.3 on a project and got the same issue - but i'm with you, that this issue is serious

@timneutkens
Copy link
Member

Released in 8.1

@tiago-pinheiro
Copy link

It would be nice to have this revert with on a 8.0.5 version since moving to version 8.1 has some problems with IOS9 :(

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants