Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page resolution #6920

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Fix page resolution #6920

merged 1 commit into from
Apr 6, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Apr 6, 2019

Previously this didn't work properly with nested pages.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js fix-page-resolving Change
Build Duration 12.2s 12.2s ⚠️ +37ms
node_modules Size 44 MB 44 MB ⚠️ +405 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 8.85 kB 8.85 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.6 kB 24.6 kB
Client main gzip Size 8.03 kB 8.03 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.5 kB 59.5 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 348 kB 348 kB
Click to expand serverless stats
zeit/next.js canary Timer/next.js fix-page-resolving Change
Build Duration 15s 15.3s ⚠️ +267ms
node_modules Size 44 MB 44 MB ⚠️ +405 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 8.85 kB 8.85 kB
Client _error gzip Size 3.31 kB 3.31 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.6 kB 24.6 kB
Client main gzip Size 8.03 kB 8.03 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.5 kB 59.5 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 237 kB 237 kB
Serverless pages/link gzip Size 62.5 kB 62.5 kB ⚠️ +1 B
Serverless pages/index Size 232 kB 232 kB
Serverless pages/index gzip Size 61.3 kB 61.3 kB
Serverless pages/_error Size 234 kB 234 kB
Serverless pages/_error gzip Size 61.2 kB 61.2 kB ⚠️ +2 B
Serverless pages/routerDirect Size 233 kB 233 kB
Serverless pages/routerDirect gzip Size 61.3 kB 61.3 kB
Serverless pages/withRouter Size 233 kB 233 kB
Serverless pages/withRouter gzip Size 61.3 kB 61.3 kB
Build Dir Size 1.4 MB 1.4 MB

@timneutkens timneutkens merged commit a67b6ee into vercel:canary Apr 6, 2019
@Timer Timer deleted the fix-page-resolving branch April 6, 2019 20:22
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants