Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove previous cache logic #7794

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Remove previous cache logic #7794

merged 2 commits into from
Jul 8, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 8, 2019

Removes previous stale-while-revalidate header when no getInitialProps is added to a page. This has been replaced with auto exporting and is no longer needed.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js remove/old-cache-logic Change
Build Duration 14.6s 14.3s -310ms
node_modules Size 45.4 MB 45.4 MB -962 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -198 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -85 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.03 kB 2.03 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.97 kB 7.97 kB ✓
Client commons Size 183 kB 183 kB -198 B
Client commons gzip Size 59.6 kB 59.5 kB -85 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.36 kB 1.36 kB ✓
Build Dir Size 786 kB 785 kB -959 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js remove/old-cache-logic Change
Build Duration 15.9s 16.4s ⚠️ +442ms
node_modules Size 45.4 MB 45.4 MB -962 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -198 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -85 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.03 kB 2.03 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.97 kB 7.97 kB ✓
Client commons Size 183 kB 183 kB -198 B
Client commons gzip Size 59.6 kB 59.5 kB -85 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 338 kB 338 kB -549 B
Serverless pages/link gzip Size 86.9 kB 86.7 kB -135 B
Serverless pages/index Size Error getting size Error getting size ✓
Serverless pages/index gzip Size Error getting size Error getting size ✓
Serverless pages/_error Size 329 kB 328 kB -549 B
Serverless pages/_error gzip Size 84.1 kB 84 kB -141 B
Serverless pages/routerDirect Size 330 kB 329 kB -549 B
Serverless pages/routerDirect gzip Size 84.4 kB 84.3 kB -138 B
Serverless pages/withRouter Size 330 kB 329 kB -549 B
Serverless pages/withRouter gzip Size 84.4 kB 84.2 kB -137 B
Build Dir Size 2.04 MB 2.04 MB -3.71 kB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js remove/old-cache-logic Change
Build Duration 13.3s 13.3s ⚠️ +12ms
node_modules Size 45.4 MB 45.4 MB -962 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -198 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -85 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.03 kB 2.03 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.97 kB 7.97 kB ✓
Client commons Size 183 kB 183 kB -198 B
Client commons gzip Size 59.6 kB 59.5 kB -85 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.36 kB 1.36 kB ✓
Build Dir Size 786 kB 785 kB -959 B
Click to expand serverless stats
zeit/next.js canary ijjk/next.js remove/old-cache-logic Change
Build Duration 15s 15s ⚠️ +12ms
node_modules Size 45.4 MB 45.4 MB -962 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB -198 B
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.8 kB -85 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.45 kB 8.45 kB ✓
Client _error gzip Size 3.24 kB 3.24 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.76 kB 4.76 kB ✓
Client pages/link gzip Size 2.03 kB 2.03 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.97 kB 7.97 kB ✓
Client commons Size 183 kB 183 kB -198 B
Client commons gzip Size 59.6 kB 59.5 kB -85 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 338 kB 338 kB -549 B
Serverless pages/link gzip Size 86.9 kB 86.7 kB -132 B
Serverless pages/index Size Error getting size Error getting size ✓
Serverless pages/index gzip Size Error getting size Error getting size ✓
Serverless pages/_error Size 329 kB 328 kB -549 B
Serverless pages/_error gzip Size 84.1 kB 84 kB -140 B
Serverless pages/routerDirect Size 330 kB 329 kB -549 B
Serverless pages/routerDirect gzip Size 84.4 kB 84.3 kB -135 B
Serverless pages/withRouter Size 330 kB 329 kB -549 B
Serverless pages/withRouter gzip Size 84.4 kB 84.2 kB -136 B
Build Dir Size 2.04 MB 2.04 MB -3.71 kB

@Timer Timer merged commit a7171db into vercel:canary Jul 8, 2019
@Timer Timer added this to the 9.0.1 milestone Jul 8, 2019
@ijjk ijjk deleted the remove/old-cache-logic branch July 8, 2019 20:45
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @Timer