-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated with-jest example to latest versions #9490
Merged
timneutkens
merged 7 commits into
vercel:canary
from
aganglada:feature/update-with-jest-example
Nov 23, 2019
Merged
Updated with-jest example to latest versions #9490
timneutkens
merged 7 commits into
vercel:canary
from
aganglada:feature/update-with-jest-example
Nov 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: e6b3568 |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: fcf38d3 |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
buildDuration | 13.6s | 13.9s | |
nodeModulesSize | 48.3 MB | 48.3 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
main-HASH.js | 17.9 kB | 17.9 kB | ✓ |
main-HASH.js gzip | 6.33 kB | 6.33 kB | ✓ |
webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
16b1a7225520..ebc17c08d.js | 19.8 kB | 19.8 kB | ✓ |
16b1a7225520..c08d.js gzip | 7.35 kB | 7.35 kB | ✓ |
4952ddcd88e7..49d7903c2.js | 9.6 kB | 9.6 kB | ✓ |
4952ddcd88e7..03c2.js gzip | 3.76 kB | 3.76 kB | ✓ |
commons.HASH.js | 10.4 kB | 10.4 kB | ✓ |
commons.HASH.js gzip | 3.91 kB | 3.91 kB | ✓ |
de003c3a9d30..a824c82eb.js | 28.3 kB | 28.3 kB | ✓ |
de003c3a9d30..82eb.js gzip | 10.7 kB | 10.7 kB | ✓ |
framework.HASH.js | 125 kB | 125 kB | ✓ |
framework.HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 213 kB | 213 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
main-HASH.module.js | 14.1 kB | 14.1 kB | ✓ |
main-HASH.module.js gzip | 5.3 kB | 5.3 kB | ✓ |
webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
16b1a7225520..9a.module.js | 21.3 kB | 21.3 kB | ✓ |
16b1a7225520..dule.js gzip | 8.14 kB | 8.14 kB | ✓ |
4952ddcd88e7..cc.module.js | 11.9 kB | 11.9 kB | ✓ |
4952ddcd88e7..dule.js gzip | 4.43 kB | 4.43 kB | ✓ |
de003c3a9d30..36.module.js | 22.2 kB | 22.2 kB | ✓ |
de003c3a9d30..dule.js gzip | 8.71 kB | 8.71 kB | ✓ |
framework.HASH.module.js | 125 kB | 125 kB | ✓ |
framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 196 kB | 196 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
polyfills-HASH.js | 9.11 kB | 9.11 kB | ✓ |
polyfills-HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
Overall change | 9.11 kB | 9.11 kB | ✓ |
Client Pages
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
_app.js | 2.92 kB | 2.92 kB | ✓ |
_app.js gzip | 1.32 kB | 1.32 kB | ✓ |
_error.js | 13.2 kB | 13.2 kB | ✓ |
_error.js gzip | 5.1 kB | 5.1 kB | ✓ |
hooks.js | 1.92 kB | 1.92 kB | ✓ |
hooks.js gzip | 941 B | 941 B | ✓ |
index.js | 318 B | 318 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js | 6.76 kB | 6.76 kB | ✓ |
link.js gzip | 2.88 kB | 2.88 kB | ✓ |
routerDirect.js | 413 B | 413 B | ✓ |
routerDirect.js gzip | 285 B | 285 B | ✓ |
withRouter.js | 423 B | 423 B | ✓ |
withRouter.js gzip | 284 B | 284 B | ✓ |
Overall change | 26 kB | 26 kB | ✓ |
Client Pages Modern
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
_app.module.js | 1.54 kB | 1.54 kB | ✓ |
_app.module.js gzip | 759 B | 759 B | ✓ |
_error.module.js | 10.5 kB | 10.5 kB | ✓ |
_error.module.js gzip | 4.26 kB | 4.26 kB | ✓ |
hooks.module.js | 677 B | 677 B | ✓ |
hooks.module.js gzip | 384 B | 384 B | ✓ |
index.module.js | 292 B | 292 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js | 5.49 kB | 5.49 kB | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect.module.js | 399 B | 399 B | ✓ |
routerDirect..dule.js gzip | 285 B | 285 B | ✓ |
withRouter.module.js | 409 B | 409 B | ✓ |
withRouter.m..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 19.3 kB | 19.3 kB | ✓ |
Client Build Manifests
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
_buildManifest.js | 244 B | 244 B | ✓ |
_buildManifest.js gzip | 201 B | 201 B | ✓ |
_buildManifest.module.js | 251 B | 251 B | ✓ |
_buildManife..dule.js gzip | 208 B | 208 B | ✓ |
Overall change | 495 B | 495 B | ✓ |
Serverless bundles
zeit/next.js canary | aganglada/next.js feature/update-with-jest-example | Change | |
---|---|---|---|
_error.js | 255 kB | 255 kB | ✓ |
_error.js gzip | 67.9 kB | 67.9 kB | ✓ |
hooks.html | 4.19 kB | 4.19 kB | ✓ |
hooks.html gzip | 1.07 kB | 1.07 kB | ✓ |
index.js | 256 kB | 256 kB | ✓ |
index.js gzip | 68 kB | 68 kB | ✓ |
link.js | 288 kB | 288 kB | ✓ |
link.js gzip | 77.1 kB | 77.1 kB | ✓ |
routerDirect.js | 281 kB | 281 kB | ✓ |
routerDirect.js gzip | 75.1 kB | 75.1 kB | ✓ |
withRouter.js | 281 kB | 281 kB | ✓ |
withRouter.js gzip | 75.2 kB | 75.2 kB | ✓ |
Overall change | 1.37 MB | 1.37 MB | ✓ |
Commit: 40f167b
…/update-with-jest-example
…/update-with-jest-example
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: bcf766c |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 7fcbd59 |
@Timer Hey! There are failing test here which doesn't seem to be related with what I've changed. Are you aware of that? Just checking, it's my first PR to the repo. |
timneutkens
approved these changes
Nov 23, 2019
@aganglada yeah that was unrelated to your changes, thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #9428, updated the example with the latest versions.