Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing getStaticProps error in serverless mode #9532

Merged
merged 5 commits into from Nov 28, 2019
Merged

Fix missing getStaticProps error in serverless mode #9532

merged 5 commits into from Nov 28, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 26, 2019

We show an error when getStaticParams is added to a page without getStaticProps although the error was not being triggered when built in serverless mode. I also moved the test to it's own suite since it was only being tested for dev mode before

@ijjk
Copy link
Member Author

ijjk commented Nov 26, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
buildDuration 14.3s 14.3s ⚠️ +10ms
nodeModulesSize 48.6 MB 48.6 MB ⚠️ +168 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.39 kB 6.39 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..4086094cc.js 19.8 kB 19.8 kB ✓
16b1a7225520..94cc.js gzip 7.37 kB 7.37 kB ✓
4952ddcd88e7..49d7903c2.js 9.6 kB 9.6 kB ✓
4952ddcd88e7..03c2.js gzip 3.76 kB 3.76 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..64b97c6d1.js 21.1 kB 21.1 kB ✓
de003c3a9d30..c6d1.js gzip 8.15 kB 8.15 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 206 kB 206 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.33 kB 5.33 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..95.module.js 21.1 kB 21.1 kB ✓
16b1a7225520..dule.js gzip 8.14 kB 8.14 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.41 kB 4.41 kB ✓
de003c3a9d30..f3.module.js 14.9 kB 14.9 kB ✓
de003c3a9d30..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.75 kB 4.75 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
_app.js 2.92 kB 2.92 kB ✓
_app.js gzip 1.32 kB 1.32 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.1 kB 5.1 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.76 kB 6.76 kB ✓
link.js gzip 2.88 kB 2.88 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 745 B 745 B ✓
_error.module.js 10.4 kB 10.4 kB ✓
_error.module.js gzip 4.25 kB 4.25 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.44 kB 5.44 kB ✓
link.module.js gzip 2.45 kB 2.45 kB ✓
routerDirect.module.js 386 B 386 B ✓
routerDirect..dule.js gzip 275 B 275 B ✓
withRouter.module.js 396 B 396 B ✓
withRouter.m..dule.js gzip 274 B 274 B ✓
Overall change 19.1 kB 19.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 200 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
index.html 4.06 kB 4.06 kB ✓
index.html gzip 1.03 kB 1.03 kB ✓
link.html 4.58 kB 4.58 kB ✓
link.html gzip 1.11 kB 1.11 kB ✓
withRouter.html 4.59 kB 4.59 kB ✓
withRouter.html gzip 1.1 kB 1.1 kB ✓
Overall change 13.2 kB 13.2 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
buildDuration 14.7s 14.8s ⚠️ +56ms
nodeModulesSize 48.6 MB 48.6 MB ⚠️ +168 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.39 kB 6.39 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..4086094cc.js 19.8 kB 19.8 kB ✓
16b1a7225520..94cc.js gzip 7.37 kB 7.37 kB ✓
4952ddcd88e7..49d7903c2.js 9.6 kB 9.6 kB ✓
4952ddcd88e7..03c2.js gzip 3.76 kB 3.76 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..64b97c6d1.js 21.1 kB 21.1 kB ✓
de003c3a9d30..c6d1.js gzip 8.15 kB 8.15 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 206 kB 206 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.33 kB 5.33 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..95.module.js 21.1 kB 21.1 kB ✓
16b1a7225520..dule.js gzip 8.14 kB 8.14 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.41 kB 4.41 kB ✓
de003c3a9d30..f3.module.js 14.9 kB 14.9 kB ✓
de003c3a9d30..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.75 kB 4.75 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
_app.js 2.92 kB 2.92 kB ✓
_app.js gzip 1.32 kB 1.32 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.1 kB 5.1 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.76 kB 6.76 kB ✓
link.js gzip 2.88 kB 2.88 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 745 B 745 B ✓
_error.module.js 10.4 kB 10.4 kB ✓
_error.module.js gzip 4.25 kB 4.25 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.44 kB 5.44 kB ✓
link.module.js gzip 2.45 kB 2.45 kB ✓
routerDirect.module.js 386 B 386 B ✓
routerDirect..dule.js gzip 275 B 275 B ✓
withRouter.module.js 396 B 396 B ✓
withRouter.m..dule.js gzip 274 B 274 B ✓
Overall change 19.1 kB 19.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 200 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 210 B 210 B ✓
Overall change 495 B 495 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/getStaticParams-error Change
_error.js 256 kB 256 kB ⚠️ +229 B
_error.js gzip 67.9 kB 68 kB ⚠️ +22 B
hooks.html 4.19 kB 4.19 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js 256 kB 256 kB ⚠️ +229 B
index.js gzip 68.1 kB 68.1 kB ⚠️ +31 B
link.js 288 kB 289 kB ⚠️ +229 B
link.js gzip 77.2 kB 77.2 kB ⚠️ +24 B
routerDirect.js 281 kB 282 kB ⚠️ +229 B
routerDirect.js gzip 75.2 kB 75.2 kB ⚠️ +25 B
withRouter.js 281 kB 282 kB ⚠️ +229 B
withRouter.js gzip 75.3 kB 75.3 kB ⚠️ +26 B
Overall change 1.37 MB 1.37 MB ⚠️ +1.15 kB

Commit: a76e67e

@ijjk ijjk added the Type: Bug label Nov 27, 2019
@ijjk ijjk added this to the 9.1.5 milestone Nov 27, 2019
@Timer Timer changed the title Make sure to show missing getStaticProps error in serverless mode Fix missing getStaticProps error in serverless mode Nov 28, 2019
@Timer
Copy link
Member

Timer commented Nov 28, 2019

Bug => "Documentation" since this isn't a stable feature yet.

@Timer Timer merged commit 89b22d2 into vercel:canary Nov 28, 2019
@Timer Timer deleted the fix/getStaticParams-error branch November 28, 2019 04:23
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @Timer