Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor next-server some for easier page checking #9671

Merged
merged 7 commits into from
Dec 10, 2019
Merged

Refactor next-server some for easier page checking #9671

merged 7 commits into from
Dec 10, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 9, 2019 •
edited
Loading

This refactors next-server and next-dev-server a bit to make it easier to check if a page exists. This leads into #9568

@ijjk
Copy link
Member Author

ijjk commented Dec 9, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js refactor/next-server Change
buildDuration 13.8s 13.5s -334ms
nodeModulesSize 46.8 MB 46.8 MB -181 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.43 kB 6.43 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..10012f496.js 20 kB 20 kB ✓
16b1a7225520..f496.js gzip 7.42 kB 7.42 kB ✓
4952ddcd88e7..49d7903c2.js 9.61 kB 9.61 kB ✓
4952ddcd88e7..03c2.js gzip 3.77 kB 3.77 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a5a0ede39.js 21.2 kB 21.2 kB ✓
de003c3a9d30..de39.js gzip 8.19 kB 8.19 kB ✓
framework.HASH.js 126 kB 126 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 207 kB 207 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.module.js 14.2 kB 14.2 kB ✓
main-HASH.module.js gzip 5.36 kB 5.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..e5.module.js 21.2 kB 21.2 kB ✓
16b1a7225520..dule.js gzip 8.18 kB 8.18 kB ✓
4952ddcd88e7..60.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.42 kB 4.42 kB ✓
de003c3a9d30..80.module.js 15 kB 15 kB ✓
de003c3a9d30..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HASH.module.js 126 kB 126 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js refactor/next-server Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.js 2.93 kB 2.93 kB ✓
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.11 kB 5.11 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 943 B 943 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.78 kB 6.78 kB ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 745 B 745 B ✓
_error.module.js 10.3 kB 10.3 kB ✓
_error.module.js gzip 4.24 kB 4.24 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.45 kB 5.45 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 386 B 386 B ✓
routerDirect..dule.js gzip 275 B 275 B ✓
withRouter.module.js 396 B 396 B ✓
withRouter.m..dule.js gzip 274 B 274 B ✓
Overall change 19 kB 19 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js refactor/next-server Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 200 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js refactor/next-server Change
index.html 4.06 kB 4.06 kB ✓
index.html gzip 1.04 kB 1.04 kB ✓
link.html 4.58 kB 4.58 kB ✓
link.html gzip 1.11 kB 1.11 kB ✓
withRouter.html 4.59 kB 4.59 kB ✓
withRouter.html gzip 1.1 kB 1.1 kB ✓
Overall change 13.2 kB 13.2 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js refactor/next-server Change
buildDuration 14s 14.1s ⚠️ +19ms
nodeModulesSize 46.8 MB 46.8 MB -181 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.43 kB 6.43 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..10012f496.js 20 kB 20 kB ✓
16b1a7225520..f496.js gzip 7.42 kB 7.42 kB ✓
4952ddcd88e7..49d7903c2.js 9.61 kB 9.61 kB ✓
4952ddcd88e7..03c2.js gzip 3.77 kB 3.77 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a5a0ede39.js 21.2 kB 21.2 kB ✓
de003c3a9d30..de39.js gzip 8.19 kB 8.19 kB ✓
framework.HASH.js 126 kB 126 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 207 kB 207 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.module.js 14.2 kB 14.2 kB ✓
main-HASH.module.js gzip 5.36 kB 5.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..e5.module.js 21.2 kB 21.2 kB ✓
16b1a7225520..dule.js gzip 8.18 kB 8.18 kB ✓
4952ddcd88e7..60.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.42 kB 4.42 kB ✓
de003c3a9d30..80.module.js 15 kB 15 kB ✓
de003c3a9d30..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HASH.module.js 126 kB 126 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js refactor/next-server Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.js 2.93 kB 2.93 kB ✓
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.11 kB 5.11 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 943 B 943 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.78 kB 6.78 kB ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 745 B 745 B ✓
_error.module.js 10.3 kB 10.3 kB ✓
_error.module.js gzip 4.24 kB 4.24 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.45 kB 5.45 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 386 B 386 B ✓
routerDirect..dule.js gzip 275 B 275 B ✓
withRouter.module.js 396 B 396 B ✓
withRouter.m..dule.js gzip 274 B 274 B ✓
Overall change 19 kB 19 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js refactor/next-server Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 200 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js refactor/next-server Change
_error.js 256 kB 256 kB ✓
_error.js gzip 67.9 kB 67.9 kB ✓
hooks.html 4.19 kB 4.19 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js 256 kB 256 kB ✓
index.js gzip 68 kB 68 kB ✓
link.js 289 kB 289 kB ✓
link.js gzip 77.2 kB 77.2 kB ✓
routerDirect.js 282 kB 282 kB ✓
routerDirect.js gzip 75.2 kB 75.2 kB ✓
withRouter.js 282 kB 282 kB ✓
withRouter.js gzip 75.3 kB 75.3 kB ✓
Overall change 1.37 MB 1.37 MB ✓

Commit: 44b1ad3

@ijjk ijjk marked this pull request as ready for review December 9, 2019 19:07
@ijjk ijjk added this to the 9.1.5 milestone Dec 9, 2019
@ijjk
Copy link
Member Author

ijjk commented Dec 9, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js refactor/next-server Change
buildDuration 13.5s 13.6s ⚠️ +93ms
nodeModulesSize 46.9 MB 46.9 MB -181 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.43 kB 6.43 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..10012f496.js 20 kB 20 kB ✓
16b1a7225520..f496.js gzip 7.42 kB 7.42 kB ✓
4952ddcd88e7..49d7903c2.js 9.61 kB 9.61 kB ✓
4952ddcd88e7..03c2.js gzip 3.77 kB 3.77 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a5a0ede39.js 21.2 kB 21.2 kB ✓
de003c3a9d30..de39.js gzip 8.19 kB 8.19 kB ✓
framework.HASH.js 126 kB 126 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 207 kB 207 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.module.js 14.2 kB 14.2 kB ✓
main-HASH.module.js gzip 5.36 kB 5.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..e5.module.js 21.2 kB 21.2 kB ✓
16b1a7225520..dule.js gzip 8.18 kB 8.18 kB ✓
4952ddcd88e7..60.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.42 kB 4.42 kB ✓
de003c3a9d30..80.module.js 15 kB 15 kB ✓
de003c3a9d30..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HASH.module.js 126 kB 126 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js refactor/next-server Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.js 2.93 kB 2.93 kB ✓
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.11 kB 5.11 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 943 B 943 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.78 kB 6.78 kB ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 745 B 745 B ✓
_error.module.js 10.3 kB 10.3 kB ✓
_error.module.js gzip 4.24 kB 4.24 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.45 kB 5.45 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 386 B 386 B ✓
routerDirect..dule.js gzip 275 B 275 B ✓
withRouter.module.js 396 B 396 B ✓
withRouter.m..dule.js gzip 274 B 274 B ✓
Overall change 19 kB 19 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js refactor/next-server Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 200 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js refactor/next-server Change
index.html 4.06 kB 4.06 kB ✓
index.html gzip 1.04 kB 1.04 kB ✓
link.html 4.58 kB 4.58 kB ✓
link.html gzip 1.11 kB 1.11 kB ✓
withRouter.html 4.59 kB 4.59 kB ✓
withRouter.html gzip 1.1 kB 1.1 kB ✓
Overall change 13.2 kB 13.2 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js refactor/next-server Change
buildDuration 13.9s 13.9s ✓
nodeModulesSize 46.9 MB 46.9 MB -181 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.43 kB 6.43 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..10012f496.js 20 kB 20 kB ✓
16b1a7225520..f496.js gzip 7.42 kB 7.42 kB ✓
4952ddcd88e7..49d7903c2.js 9.61 kB 9.61 kB ✓
4952ddcd88e7..03c2.js gzip 3.77 kB 3.77 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..a5a0ede39.js 21.2 kB 21.2 kB ✓
de003c3a9d30..de39.js gzip 8.19 kB 8.19 kB ✓
framework.HASH.js 126 kB 126 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 207 kB 207 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.module.js 14.2 kB 14.2 kB ✓
main-HASH.module.js gzip 5.36 kB 5.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..e5.module.js 21.2 kB 21.2 kB ✓
16b1a7225520..dule.js gzip 8.18 kB 8.18 kB ✓
4952ddcd88e7..60.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.42 kB 4.42 kB ✓
de003c3a9d30..80.module.js 15 kB 15 kB ✓
de003c3a9d30..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HASH.module.js 126 kB 126 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js refactor/next-server Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.js 2.93 kB 2.93 kB ✓
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js 13.2 kB 13.2 kB ✓
_error.js gzip 5.11 kB 5.11 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 943 B 943 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.78 kB 6.78 kB ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 26 kB 26 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 745 B 745 B ✓
_error.module.js 10.3 kB 10.3 kB ✓
_error.module.js gzip 4.24 kB 4.24 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.45 kB 5.45 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 386 B 386 B ✓
routerDirect..dule.js gzip 275 B 275 B ✓
withRouter.module.js 396 B 396 B ✓
withRouter.m..dule.js gzip 274 B 274 B ✓
Overall change 19 kB 19 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js refactor/next-server Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 200 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js refactor/next-server Change
_error.js 256 kB 256 kB ✓
_error.js gzip 67.9 kB 67.9 kB ✓
hooks.html 4.19 kB 4.19 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js 256 kB 256 kB ✓
index.js gzip 68 kB 68 kB ✓
link.js 289 kB 289 kB ✓
link.js gzip 77.2 kB 77.2 kB ✓
routerDirect.js 282 kB 282 kB ✓
routerDirect.js gzip 75.2 kB 75.2 kB ✓
withRouter.js 282 kB 282 kB ✓
withRouter.js gzip 75.3 kB 75.3 kB ✓
Overall change 1.37 MB 1.37 MB ✓

Commit: 6239a81

@Timer Timer modified the milestones: 9.1.5, 9.1.6 Dec 10, 2019
@ijjk
Copy link
Member Author

ijjk commented Dec 10, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js refactor/next-server Change
buildDuration 13.6s 13.9s ⚠️ +320ms
nodeModulesSize 46.9 MB 46.9 MB -220 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.43 kB 6.43 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..1db6754d3.js 12 kB 12 kB ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js 10.9 kB 10.9 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..4155a1d0b.js 38.3 kB 38.3 kB ✓
de003c3a9d30..1d0b.js gzip 13.9 kB 13.9 kB ✓
framework.HASH.js 126 kB 126 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 207 kB 207 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.module.js 14.2 kB 14.2 kB ✓
main-HASH.module.js gzip 5.36 kB 5.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..b9.module.js 14.9 kB 14.9 kB ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..8b.module.js 33.1 kB 33.1 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HASH.module.js 126 kB 126 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js refactor/next-server Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.js 2.94 kB 2.94 kB ✓
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js 10.4 kB 10.4 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js 1.44 kB 1.44 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.77 kB 6.77 kB ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 22.7 kB 22.7 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 757 B 757 B ✓
_error.module.js 7.35 kB 7.35 kB ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.45 kB 5.45 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 383 B 383 B ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.module.js 394 B 394 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js refactor/next-server Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js refactor/next-server Change
index.html 4.06 kB 4.06 kB ✓
index.html gzip 1.04 kB 1.04 kB ✓
link.html 4.11 kB 4.11 kB ✓
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html 4.12 kB 4.12 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 12.3 kB 12.3 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js refactor/next-server Change
buildDuration 13.9s 13.9s ⚠️ +64ms
nodeModulesSize 46.9 MB 46.9 MB -220 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.43 kB 6.43 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..1db6754d3.js 12 kB 12 kB ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js 10.9 kB 10.9 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..4155a1d0b.js 38.3 kB 38.3 kB ✓
de003c3a9d30..1d0b.js gzip 13.9 kB 13.9 kB ✓
framework.HASH.js 126 kB 126 kB ✓
framework.HASH.js gzip 39.5 kB 39.5 kB ✓
Overall change 207 kB 207 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
main-HASH.module.js 14.2 kB 14.2 kB ✓
main-HASH.module.js gzip 5.36 kB 5.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..b9.module.js 14.9 kB 14.9 kB ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..8b.module.js 33.1 kB 33.1 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HASH.module.js 126 kB 126 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js refactor/next-server Change
polyfills-HASH.js 15.3 kB 15.3 kB ✓
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 15.3 kB 15.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.js 2.94 kB 2.94 kB ✓
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js 10.4 kB 10.4 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js 1.44 kB 1.44 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 6.77 kB 6.77 kB ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 22.7 kB 22.7 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js refactor/next-server Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 757 B 757 B ✓
_error.module.js 7.35 kB 7.35 kB ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js 651 B 651 B ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js 276 B 276 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js 5.45 kB 5.45 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 383 B 383 B ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.module.js 394 B 394 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js refactor/next-server Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js refactor/next-server Change
_error.js 280 kB 280 kB ✓
_error.js gzip 74.8 kB 74.8 kB ✓
hooks.html 4.19 kB 4.19 kB ✓
hooks.html gzip 1.07 kB 1.07 kB ✓
index.js 281 kB 281 kB ✓
index.js gzip 75.1 kB 75.1 kB ✓
link.js 288 kB 288 kB ✓
link.js gzip 77.1 kB 77.1 kB ✓
routerDirect.js 281 kB 281 kB ✓
routerDirect.js gzip 75.1 kB 75.1 kB ✓
withRouter.js 281 kB 281 kB ✓
withRouter.js gzip 75.2 kB 75.2 kB ✓
Overall change 1.42 MB 1.42 MB ✓

Commit: fe4a2fd

@Timer Timer merged commit da1ef50 into vercel:canary Dec 10, 2019
@Timer Timer deleted the refactor/next-server branch December 10, 2019 15:08
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2019
Closed
This was referenced Jan 7, 2020
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @Timer