Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the handling of user errors #1959

Merged
merged 4 commits into from Mar 15, 2019
Merged
Diff settings

Always

Just for now

@@ -459,6 +459,12 @@ export default async function main(
error(message);
}

if (err.code === 'size_limit_exceeded') {
const message = `File size limit exceeded (${bytes(err.sizeLimit)})`;
This conversation was marked as resolved by juliangruber

This comment has been minimized.

Copy link
@juliangruber

juliangruber Mar 13, 2019

Author Contributor

is this input to be trusted?

This comment has been minimized.

Copy link
@leo

leo Mar 14, 2019

Member

@juliangruber Let's add a check for whether the property is there.

error(message);
return 1;
}

handleError(err);
return 1;
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.