[now-routing-utils] Add replacing of multi-match characters

[ijjk]

This makes sure to replace multi-match characters used in path-to-regexp when converting redirects.

Fixes /:path*/ being converted to /$1*/ and now converts it to /$1/

[dav-is]

Given this affects rewrites too, can we add tests there as well

[ijjk]

Added tests for rewrites also

[styfle]

Let's use compile() like we discussed.

compile('/:user/:users')({ user: '$1', users: '$2' })
compile('/:user*/:users')({ user: '$1', users: '$2' })
compile('/:user/:user')({ user: '$1' })

[ijjk]

Updated to use pathToRegexp.compile 👍

changes

[codecov-io]

Codecov Report

Merging #3446 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3446   +/-   ##
=======================================
  Coverage   14.56%   14.56%           
=======================================
  Files         267      267           
  Lines       10784    10784           
  Branches     1482     1482           
=======================================
  Hits         1571     1571           
  Misses       9047     9047           
  Partials      166      166

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9687415...ac17cd2. Read the comment docs.

[styfle]

I think we need a few additional tests for full URLs such as

{ source: '/firebase/:id', destination: 'https://:id.firebase.com' }
{ source: '/firebase/:id', destination: 'https://:id.firebase.com:8080' }
{ source: '/firebase/:id', destination: 'https://www.firebase.com:8080?userid=:id' }

[ijjk]

Added more tests as we talked about

[styfle]

Amazing work 🎉