Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-static-build] Add caching headers for Stencil #3493

Merged
merged 6 commits into from
Jan 31, 2020
Merged

[now-static-build] Add caching headers for Stencil #3493

merged 6 commits into from
Jan 31, 2020

Conversation

simonhaenisch
Copy link
Contributor

@adamdbradley
Copy link

This looks great! 👍

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #3493 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3493      +/-   ##
==========================================
- Coverage   14.59%   14.56%   -0.04%     
==========================================
  Files         267      267              
  Lines       10779    10774       -5     
  Branches     1483     1484       +1     
==========================================
- Hits         1573     1569       -4     
+ Misses       9039     9038       -1     
  Partials      167      167
Impacted Files Coverage Δ
src/util/metrics.ts 61.53% <0%> (-6.65%) ⬇️
src/util/prefer-v2-deployment.ts 55.1% <0%> (-4.9%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 19.04% <0%> (-4.49%) ⬇️
src/util/dev/server.ts 59.66% <0%> (+0.05%) ⬆️
src/util/dev/builder.ts 65.88% <0%> (+0.59%) ⬆️
src/util/get-update-command.ts 10% <0%> (+0.62%) ⬆️
src/util/dev/yarn-installer.ts 83.33% <0%> (+3.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d2f8b...33e7bdd. Read the comment docs.

@styfle styfle changed the title [frameworks] add caching headers for Stencil [now-static-build] Add caching headers for Stencil Jan 3, 2020
@simonhaenisch
Copy link
Contributor Author

I've done the requested changes... would someone mind having a look again, please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants