[now-static-build][frameworks][examples] Fixes examples and adjust frameworks #3584
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/zeit/now/lw2ma68gf |
AndyBitz
requested review from
leo,
mcsdevv,
styfle,
Timer,
timneutkens,
timothyis and
TooTallNate
as code owners
| @@ -145,6 +168,7 @@ export const frameworks: Framework[] = [ | |||
| slug: 'angular', | |||
| dependency: '@angular/cli', | |||
| minNodeRange: '10.x', | |||
There was a problem hiding this comment.
You can remove minNodeRange since it doesn't do anything anymore
| getOutputDirName: async () => 'public', | ||
| }, | ||
| { | ||
| name: 'Middleman', | ||
| slug: 'middleman', | ||
| buildCommand: 'bundle exec middleman build', | ||
| devCommand: 'bundle exec middleman server -p $PORT', |
There was a problem hiding this comment.
Why was the dev command removed for middleman?
There was a problem hiding this comment.
@styfle all devCommands were removed since they are part of @now/frameworks`, so they are not really removed, they'll just be added at a later time
There was a problem hiding this comment.
@AndyBitz Then why did you add devCommand: 'nuxt', above?
There was a problem hiding this comment.
@styfle Good catch, that was a mistake
nowfilewithpathinframeworks.json@now/static-builduses thepackage.jsonscript if present instead of the framework provided one