Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MaxMarketLifetime a constant #1014

Merged
merged 1 commit into from Jun 9, 2023
Merged

Make MaxMarketLifetime a constant #1014

merged 1 commit into from Jun 9, 2023

Conversation

maltekliemann
Copy link
Member

This fixed an oversight from the PR introducing the MaxMarketLifetime config parameter.

@maltekliemann maltekliemann added the s:in-progress The pull requests is currently being worked on label May 31, 2023
@maltekliemann maltekliemann self-assigned this May 31, 2023
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Jun 2, 2023
Chralt98
Chralt98 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@Chralt98 Chralt98 left a comment •
edited by maltekliemann

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what does this mean? It adds this to the metadata.

I think you answered your own question here. It's in the metadata, which means it's exposed to whatever applications want to use it.

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jun 9, 2023
@maltekliemann maltekliemann merged commit cd1d624 into main Jun 9, 2023
11 checks passed
@maltekliemann maltekliemann deleted the mkl-fix-max-market-lifetime branch June 9, 2023 14:29
@sea212 sea212 added this to the v0.3.9 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chralt98 Chralt98 Chralt98 approved these changes

Assignees

@maltekliemann maltekliemann

Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.3.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maltekliemann @Chralt98 @sea212