Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to v0.9.37 #1059

Merged
merged 30 commits into from
Aug 4, 2023
Merged

Upgrade dependencies to v0.9.37 #1059

merged 30 commits into from
Aug 4, 2023

Conversation

@sea212 sea212 added the s:in-progress The pull requests is currently being worked on label Aug 1, 2023
@sea212 sea212 added this to the v0.3.11 milestone Aug 1, 2023
@sea212 sea212 self-assigned this Aug 1, 2023
@sea212 sea212 changed the title Upgrade v0.9.37 Upgrade dependencies Aug 1, 2023
Dependencies are defined using the following order: Either just a version, or a version/git repository, then a branch or tag, than whether default features are enabled or not
Previously in this PR std was used when the mock feature is enabled, which worked. Then it was removed, which lead to compilation issues in certain cases. Now instead of std, the default feature is enabled in every create that is activated with the mock feature.
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

⚠️ The sha of the head commit of this PR conflicts with #1060. Mergify cannot evaluate rules on this PR. ⚠️

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2023

This pull request is now in conflicts. Could you fix it @sea212? 🙏

@mergify mergify bot added s:revision-needed The pull requests must be revised and removed s:in-progress The pull requests is currently being worked on labels Aug 2, 2023
@sea212 sea212 added s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on labels Aug 3, 2023
@sea212
Copy link
Member Author

sea212 commented Aug 3, 2023

Does the dev config produce blocks? Can we connect to the peers with parachain feature? (for zeitgeist and battery station)

Yes. Standalone produces blocks and parachain nodes sync successfully for both networks. There seems to be a known bug in v0.9.37 on Rococo, where during sync the state is already discarded which slows the sync a bit down. This can be fixed though by specifying pruning as a relay argument or using a remote relay node via rpc. Following versions of Cumulus should fix this. Mainnet sync works flawless in any case.

Chralt98
Chralt98 previously approved these changes Aug 3, 2023
Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dependency upgrade is always one of the hardest to verify..

zrml/prediction-markets/Cargo.toml Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1059 (b171c2f) into main (41a2564) will increase coverage by 0.56%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
+ Coverage   92.94%   93.50%   +0.56%     
==========================================
  Files          92       92              
  Lines       21581    21581              
==========================================
+ Hits        20058    20179     +121     
+ Misses       1523     1402     -121     
Flag Coverage Δ
tests 93.50% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

node/src/command.rs Outdated Show resolved Hide resolved
@Chralt98 Chralt98 added s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on labels Aug 3, 2023
Chralt98
Chralt98 previously approved these changes Aug 3, 2023
@maltekliemann maltekliemann self-requested a review August 3, 2023 14:06
maltekliemann
maltekliemann previously approved these changes Aug 3, 2023
@@ -1,1033 +1,1323 @@
// Copyright 2022-2023 Forecasting Technologies LTD.
// Copyright 2021-2022 Zeitgeist PM LLC.
// Copyright 2023 Forecasting Technologies LTD.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems off. It seems like the Zeitgeist PM copyrights were erroneously added, but now you're completely removing the GPL-3.0-or-later from this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied this file from Parity. It will be overwritten by the benchmark shortly.

runtime/zeitgeist/build.rs Outdated Show resolved Hide resolved
Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
@sea212 sea212 dismissed stale reviews from maltekliemann and Chralt98 via 1c870bc August 3, 2023 18:52
@sea212 sea212 added s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on labels Aug 3, 2023
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 4, 2023
@sea212 sea212 merged commit 4661002 into main Aug 4, 2023
29 of 30 checks passed
@sea212 sea212 deleted the sea212-upgrade-v0.9.37 branch August 4, 2023 07:43
@Chralt98 Chralt98 changed the title Upgrade dependencies Upgrade dependencies to v0.9.37 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i:spec-changed ⚠️ Implies change in spec version i:transactions-changed ⚠️ Implies change in transaction version s:accepted This pull request is ready for merge
Projects
None yet
4 participants