-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies to v0.9.37 #1059
Conversation
Dependencies are defined using the following order: Either just a version, or a version/git repository, then a branch or tag, than whether default features are enabled or not
Previously in this PR std was used when the mock feature is enabled, which worked. Then it was removed, which lead to compilation issues in certain cases. Now instead of std, the default feature is enabled in every create that is activated with the mock feature.
|
This pull request is now in conflicts. Could you fix it @sea212? 🙏 |
Yes. Standalone produces blocks and parachain nodes sync successfully for both networks. There seems to be a known bug in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A dependency upgrade is always one of the hardest to verify..
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1059 +/- ##
==========================================
+ Coverage 92.94% 93.50% +0.56%
==========================================
Files 92 92
Lines 21581 21581
==========================================
+ Hits 20058 20179 +121
+ Misses 1523 1402 -121
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -1,1033 +1,1323 @@ | |||
// Copyright 2022-2023 Forecasting Technologies LTD. | |||
// Copyright 2021-2022 Zeitgeist PM LLC. | |||
// Copyright 2023 Forecasting Technologies LTD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems off. It seems like the Zeitgeist PM copyrights were erroneously added, but now you're completely removing the GPL-3.0-or-later from this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied this file from Parity. It will be overwritten by the benchmark shortly.
Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
What does it do?
Upgrades all substrate related dependencies to v0.9.37. Also upgrades all other dependencies to adequate versions.
Dependencies
Cumulus: https://github.com/paritytech/cumulus/tree/polkadot-v0.9.37
Moonbeam: https://github.com/PureStake/moonbeam/tree/v0.30.3
Nimbus: https://github.com/PureStake/nimbus/tree/moonbeam-polkadot-v0.9.37
ORML: https://github.com/open-web3-stack/open-runtime-module-library/tree/polkadot-v0.9.37
Polkadot: https://github.com/paritytech/polkadot/tree/release-v0.9.37
Substrate: https://github.com/paritytech/substrate/tree/polkadot-v0.9.37
Changes
Cumulus: paritytech/cumulus@polkadot-v0.9.32...polkadot-v0.9.37
Moonbeam: moonbeam-foundation/moonbeam@v0.28.1...v0.30.3
Nimbus: moonbeam-foundation/nimbus@moonbeam-polkadot-v0.9.32...moonbeam-polkadot-v0.9.37
ORML: open-web3-stack/open-runtime-module-library@polkadot-v0.9.32...polkadot-v0.9.37
Polkadot: paritytech/polkadot@release-v0.9.32...release-v0.9.37
Substrate: paritytech/substrate@polkadot-v0.9.32...polkadot-v0.9.37
Substrate-Parachain: substrate-developer-hub/substrate-parachain-template@polkadot-v0.9.32...polkadot-v0.9.37
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
closes #1040
References