Decouple benchmark dependencies from node #172
Conversation
| native_executor_instance!( | ||
| pub Executor, | ||
| zeitgeist_runtime::api::dispatch, | ||
| zeitgeist_runtime::native_version, |
There was a problem hiding this comment.
IIRC, frame_benchmarking::benchmarking::HostFunctions removal shouldn't be a problem. Still need to double check it
c410-f3r
requested review from
sea212 and
lsaether
and removed request for
sea212
| RUST_BACKTRACE=1 cargo fuzz run --fuzz-dir zrml/prediction-markets/fuzz full_workflow -- -runs=$RUNS | ||
| RUST_BACKTRACE=1 cargo fuzz run --fuzz-dir zrml/prediction-markets/fuzz pm_full_workflow -- -runs=$RUNS | ||
|
|
||
| RUST_BACKTRACE=1 cargo fuzz run --fuzz-dir zrml/swaps/fuzz full_workflow -- -runs=$RUNS | ||
| RUST_BACKTRACE=1 cargo fuzz run --fuzz-dir zrml/swaps/fuzz swaps_full_workflow -- -runs=$RUNS |
There was a problem hiding this comment.
This is a nice fix you included along the way.
| if [[ "$package" == "zrml/market-commons" ]]; then | ||
| test_package_with_feature "$package" std | ||
| continue | ||
| fi | ||
|
|
There was a problem hiding this comment.
There might be multiple pallets in the future that don't have the runtime-benchmarks feature, but I think it is reasonable to fix it when the second pallet without that feature is included.
| std = [ | ||
| "frame-benchmarking?/std", |
There was a problem hiding this comment.
What does the ? operator do in this context? (I was not able to find it in the cargo book)
There was a problem hiding this comment.
When activating an optional feature like serde/std, Cargo unconditionally also brings the whole dependency and this situation was causing some problems on CI, thus the reason for #157.
In this example, frame-benchmarking?/std means that the frame-benchmarking crate won't be included when calling cargo build --features std. rust-lang/cargo#8832
lsaether
added
s:accepted
Taking aside the benchmark decoupling from the
nodecrate, this PR also tries to remove unnecessary dependencies to speed-up builds and improve CI times.Locally,
cargo checkwent down from ~971 to ~948 crates.