Update collator parameters #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollatorDeposit (Amount necessary to map Author ID to Accout ID): 2 BondDuration (Number of rounds a collator must remain after requesting to leave): 7 * BLOCKS_PER_DAY DefaultCollatorCommission: 20% DefaultParachainBondReservePercent: 30% (????????????????) MaxCollatorsPerNominator: 16 collators MaxNominatorsPerCollator: 32 nominators MinBlocksPerRound: BLOCKS_PER_DAY. MinCollatorCandidateStk (Minimum amount of stake to become a collator candidate): 64 ZTG MinCollatorStk (Minimum amount of stake an actual collator should put on a round): 64 ZTG MinNomination (Minimum amount of stake to nominate a collator): 1 ZTG MinNominatorStk (Minimum amout of stake to become a nominator): 1 ZTG MinSelectedCandidates (Minimal amout of collator candidates to produce blocks): 1 candidades
lsaether
reviewed
Jun 21, 2021
runtime/src/lib.rs
Outdated
| @@ -93,19 +93,19 @@ pub type UncheckedExtrinsic = generic::UncheckedExtrinsic<Address, Call, Signatu | |||
|
|
|||
| parameter_types! { | |||
| pub const BlockHashCount: BlockNumber = BLOCK_HASH_COUNT; | |||
| pub const BondDuration: u32 = 1; | |||
| pub const BondDuration: u32 = 7 * BLOCKS_PER_DAY as u32; | |||
There was a problem hiding this comment.
Suggested change
| pub const BondDuration: u32 = 7 * BLOCKS_PER_DAY as u32; | |
| pub const BondDuration: u32 = BLOCKS_PER_DAY as u32; |
Shorten it for the testnet so we can change the collator set more often.
lsaether
reviewed
Jun 21, 2021
runtime/src/lib.rs
Outdated
| pub const MinBlocksPerRound: u32 = BLOCKS_PER_MINUTE as _; | ||
| pub const MinCollatorStake: u128 = 100 * BASE; | ||
| pub const MaxNominatorsPerCollator: u32 = 32; | ||
| pub const MinBlocksPerRound: u32 = BLOCKS_PER_DAY as _; |
There was a problem hiding this comment.
Suggested change
| pub const MinBlocksPerRound: u32 = BLOCKS_PER_DAY as _; | |
| pub const MinBlocksPerRound: u32 = BLOCKS_PER_DAY / 6 as _; |
6 rounds per day
lsaether
reviewed
Jun 21, 2021
runtime/src/lib.rs
Outdated
| pub const MinimumPeriod: u64 = SLOT_DURATION / 2; | ||
| pub const MinNominatorStake: u128 = 5 * BASE; | ||
| pub const MinNominatorStake: u128 = 1 * BASE; |
There was a problem hiding this comment.
Suggested change
| pub const MinNominatorStake: u128 = 1 * BASE; | |
| pub const MinNominatorStake: u128 = BASE / 2; |
since we give 1 ZBP on the faucet, this will allow someone to make just 1 faucet hit then nominate a collator
lsaether
approved these changes
Jun 21, 2021
sea212
added
s:accepted
c410-f3r
added a commit
to c410-f3r/zeitgeist
that referenced
this pull request
Sep 14, 2021
* Update collator parameters CollatorDeposit (Amount necessary to map Author ID to Accout ID): 2 BondDuration (Number of rounds a collator must remain after requesting to leave): 7 * BLOCKS_PER_DAY DefaultCollatorCommission: 20% DefaultParachainBondReservePercent: 30% (????????????????) MaxCollatorsPerNominator: 16 collators MaxNominatorsPerCollator: 32 nominators MinBlocksPerRound: BLOCKS_PER_DAY. MinCollatorCandidateStk (Minimum amount of stake to become a collator candidate): 64 ZTG MinCollatorStk (Minimum amount of stake an actual collator should put on a round): 64 ZTG MinNomination (Minimum amount of stake to nominate a collator): 1 ZTG MinNominatorStk (Minimum amout of stake to become a nominator): 1 ZTG MinSelectedCandidates (Minimal amout of collator candidates to produce blocks): 1 candidades * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, feel free to discuss better parameters.
For more information, take a look at https://github.com/PureStake/moonbeam/blob/1cde8ef9c3bb8b3832ce0beeb8fb679e1530586d/pallets/parachain-staking/src/lib.rs#L642-L673.
CollatorDeposit(Amount necessary to map Author ID to Accout ID) = 2BondDuration(Number of rounds a collator must remain after requesting to leave) = 7 * BLOCKS_PER_DAY = 7 daysDefaultCollatorCommission= 20%DefaultParachainBondReservePercent= 30% (????????????????)MaxCollatorsPerNominator= 16 collatorsMaxNominatorsPerCollator= 32 nominatorsMinBlocksPerRound= BLOCKS_PER_DAY = 1 day.MinCollatorCandidateStk(Minimum amount of stake to become a collator candidate) = 64 ZTGMinCollatorStk(Minimum amount of stake an actual collator should put on a round) = 64 ZTGMinNomination(Minimum amount of stake to nominate a collator) = 1 ZTGMinNominatorStk(Minimum amout of stake to become a nominator) = 1 ZTGMinSelectedCandidates(Minimal amout of collator candidates to produce blocks) = 1 candidade