Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amount to Bought/SoldCompleteSet event #491

Merged
merged 2 commits into from Mar 19, 2022
Merged

Add amount to Bought/SoldCompleteSet event #491

merged 2 commits into from Mar 19, 2022

Conversation

maltekliemann
Copy link
Member

@maltekliemann maltekliemann commented Mar 18, 2022 •
edited

Closes #443

@maltekliemann maltekliemann added the s:review-needed The pull request requires reviews label Mar 18, 2022
sea212
sea212 reviewed Mar 18, 2022
View reviewed changes
zrml/prediction-markets/src/lib.rs Outdated Show resolved Hide resolved
zrml/prediction-markets/src/lib.rs Outdated Show resolved Hide resolved
@sea212
Copy link
Member

sea212 commented Mar 18, 2022

cc @saboonikhil

@maltekliemann @sea212
Apply suggestions from code review
8d44eed 
Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>
@sea212 sea212 added this to the v0.3.0 milestone Mar 18, 2022
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Mar 19, 2022
@maltekliemann maltekliemann merged commit 3f6b91b into zeitgeistpm:main Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea212 sea212 sea212 approved these changes

Assignees
No one assigned
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

[Squid] Add amount as event param in BoughtCompleteSet/SoldCompleteSet
2 participants
@maltekliemann @sea212