-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separated fuzz tests, added pool_creation #542
Conversation
The fuzz extrinsics tests need further modifications to not fail at the first error possibility 100% of the time, but for now the valid pool creation works, the code is separated and the fuzz tests should be valid for a review. Later the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least once the fuzz tests panicked with a duplicate asset. Nevermind, I ran an old build. 😬
There are a couple of low-priority critiques, mostly lack of randomization. But other than that, looks like a very useful abstraction of the workflow. 👍
Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks good to me! 👍
Related to [Swaps] Improve fuzz tests #290
The approach at the moment is to fuzz test each dispatchable of the swaps pallet with random and valid pool id's.
The challenge is to check multiple combinations of valid pool id's and these dispatchables. Therefore it would be wasted time to check and find invalid pool id's.